From: Takashi Iwai <tiwai@suse.de>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda/hdmi: Remove some dead code
Date: Tue, 18 Apr 2023 08:01:28 +0200 [thread overview]
Message-ID: <877cu9685j.wl-tiwai@suse.de> (raw)
In-Reply-To: <91a31341f32d493bcc6c4515178ce0755ac1aa70.1681710069.git.christophe.jaillet@wanadoo.fr>
On Mon, 17 Apr 2023 07:41:48 +0200,
Christophe JAILLET wrote:
>
> These snd_BUG_ON() can never trigger, so just remove them to save a few
> LoC.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This patch is speculative. Maybe the other "if"s should be removed and the
> error code returned instead.
>
> I chose to remove these ones and the corresponding error code, because it
> seems that it is already handled this way in hdmi_pcm_open().
>
> I don't know the code enough, so it is only my guess.
>
> Review with care :)
A sanity check is merely a sanity check, and we haven't got report
hitting this, so this should be fine. Let's cross fingers.
thanks,
Takashi
prev parent reply other threads:[~2023-04-18 6:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 5:41 [PATCH] ALSA: hda/hdmi: Remove some dead code Christophe JAILLET
2023-04-18 6:01 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cu9685j.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox