From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54C6CC636CC for ; Thu, 16 Feb 2023 13:22:19 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D364BE12; Thu, 16 Feb 2023 14:21:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D364BE12 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1676553736; bh=3sAyq8I93Sn1ZNFBBMF1TK6zBpcx7pni0jp/3iUxjkQ=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Xi1794p27K+Nnb7wWkJhCEWuilujaYINZDsFa+S12KDESeqT+yL8csqXneQbu6d1T KrOi48K1U0jZE+tz85iqUtx1xwVGlSIj+pF9eWzvIRU1v0geHkNJFU6NWUNSHc4cmK 3PtCUo04d9DRtgkoJcqiaafqDmcYAh7m4dyXeQeU= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 5D9D7F80083; Thu, 16 Feb 2023 14:21:02 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 01364F80171; Thu, 16 Feb 2023 14:20:58 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4DD0DF80083 for ; Thu, 16 Feb 2023 14:20:54 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4DD0DF80083 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fmgnUO6t; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+eP391B+ Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 950C421D16; Thu, 16 Feb 2023 13:20:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676553654; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v5JyBkcwirWIeq0OSn+O0k4FE4Kvt8rex6mOed7tRrA=; b=fmgnUO6tJUMWyCAl90ikIHcD+QVsgNJ+X85yUTvubM6VeHRBhGkirr6ec8EBeeJ7sT96AP 2gYC/S4AfaXsD5jJAfbnMYUpicipvq486Xekd/unJRib5TgrS8tdvdd6IVgA/Pyybv5WRB 2ks8uYqEcILsN2TzTJ8sxBIa8ewd0vI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676553654; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v5JyBkcwirWIeq0OSn+O0k4FE4Kvt8rex6mOed7tRrA=; b=+eP391B+GYmkBsdtm0gPaCMhmkp8eW+nLpvVV1lmZbCAaoMPHHFM27V2Ka+UbIuNjYLwZt 5NDkkVfWXPsxeRBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 64A5E13438; Thu, 16 Feb 2023 13:20:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wthuF7Yt7mN5WQAAMHmgww (envelope-from ); Thu, 16 Feb 2023 13:20:54 +0000 Date: Thu, 16 Feb 2023 14:20:53 +0100 Message-ID: <877cwh7nm2.wl-tiwai@suse.de> From: Takashi Iwai To: Orlando Chamberlain Subject: Re: [PATCHv2] hda/hdmi: Register with vga_switcheroo on Dual GPU Macbooks In-Reply-To: <20230216103450.12925-1-orlandoch.dev@gmail.com> References: <20230216103450.12925-1-orlandoch.dev@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: WQJAJJA3NJHAZE5RFOUOEMEAAFHAWLFU X-Message-ID-Hash: WQJAJJA3NJHAZE5RFOUOEMEAAFHAWLFU X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org, Takashi Iwai , Evan Quan , Alex Deucher , linux-kernel@vger.kernel.org, Aditya Garg , Aun-Ali Zaidi , Kerem Karabay X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 16 Feb 2023 11:34:51 +0100, Orlando Chamberlain wrote: > > Commit 586bc4aab878 ("ALSA: hda/hdmi - fix vgaswitcheroo detection for > AMD") caused only AMD gpu's with PX to have their audio component register > with vga_switcheroo. This meant that Apple Macbooks with apple-gmux as the > gpu switcher no longer had the audio client registering, so when the gpu is > powered off by vga_switcheroo snd_hda_intel is unaware that it should have > suspended the device: > > amdgpu: switched off > snd_hda_intel 0000:03:00.1: > Unable to change power state from D3hot to D0, device inaccessible > snd_hda_intel 0000:03:00.1: CORB reset timeout#2, CORBRP = 65535 > > To resolve this, we use apple_gmux_detect() and register a > vga_switcheroo audio client when apple-gmux is detected. > > Fixes: 586bc4aab878 ("ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD") > Link: https://lore.kernel.org/all/20230210044826.9834-9-orlandoch.dev@gmail.com/ > Signed-off-by: Orlando Chamberlain > --- > v1->v2: Use apple_gmux_detect(), split this patch out of the patch > series Thanks, applied now. Takashi