From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55C96C43334 for ; Sat, 9 Jul 2022 16:47:31 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C31791EA; Sat, 9 Jul 2022 18:46:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C31791EA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657385248; bh=4TCpD2lGkkDcd0eWTs804lCAh2HBCz7nh3ROrGNrLvE=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Vg5lW0rAaGcJn0qD3eOMuOL81DEzO0VLpuSIgG92VYEu3hVEaGTYFNLIlOhiVD5ce w5gDXDp1QhvJa4ohmrYFxwVVUYkWhRurlN19G9OLWkRe9vpCskB9E+tI/XNjMZCuLY /459pfS9gortERenXTEcXyv5HUSJFbUSW6/57EPk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4EACBF8020D; Sat, 9 Jul 2022 18:46:38 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 08105F80245; Sat, 9 Jul 2022 18:46:36 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DAF37F80158 for ; Sat, 9 Jul 2022 18:46:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DAF37F80158 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="SB2cUKs5"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="rqin+Fly" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 77FF521F4D; Sat, 9 Jul 2022 16:46:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657385188; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vpP6aYQqpkyPWApIz8JvjE5LVmtBP9wlukIXhNCSpQU=; b=SB2cUKs5WUwjxf+bEecTpuIIKNZWQm2Z0XBIorjykbHK7LLz01s5peXkWa90e+hkDJ3sJw OUdBpIj+75aNdR6XQlvPtNjnMS1U1sT3povGeWlGL4kKnN9AICCeECr4JpbrxB9e7E1tRO L/pF+tRoTEnQJ/rfzX+gzwFsNXGin2U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657385188; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vpP6aYQqpkyPWApIz8JvjE5LVmtBP9wlukIXhNCSpQU=; b=rqin+FlysYZnEnYYB+NQNvfczkMqBF+9Tawb9WMFwvZ/oFg0nAkrlCKwlg2q4/pSLwniJ0 MAanEEx7jobtERDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 466E213482; Sat, 9 Jul 2022 16:46:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Hu1hEOSwyWIsaQAAMHmgww (envelope-from ); Sat, 09 Jul 2022 16:46:28 +0000 Date: Sat, 09 Jul 2022 18:46:27 +0200 Message-ID: <877d4mi68s.wl-tiwai@suse.de> From: Takashi Iwai To: Cezary Rojewski Subject: Re: [PATCH 9/9] ALSA: hda/realtek: Remove redundant init_hook() in alc_default_init() In-Reply-To: <20220706120230.427296-10-cezary.rojewski@intel.com> References: <20220706120230.427296-1-cezary.rojewski@intel.com> <20220706120230.427296-10-cezary.rojewski@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hdegoede@redhat.com, broonie@kernel.org, amadeuszx.slawinski@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 06 Jul 2022 14:02:30 +0200, Cezary Rojewski wrote: > > snd_hda_gen_init() does that for every codec already. Definitely not. snd_hda_gen_init() calls init_hook of snd_hda_gen_spec. OTOH, what you're trying to kill the init_hook call of alc_spec. Both are in different layers and they don't share the same callback. thanks, Takashi > > Signed-off-by: Cezary Rojewski > --- > sound/pci/hda/patch_realtek.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index f3ad454b3fbf..a8688025352d 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -923,9 +923,6 @@ static int alc_init(struct hda_codec *codec) > if (is_s4_resume(codec)) > alc_pre_init(codec); > > - if (spec->init_hook) > - spec->init_hook(codec); > - > spec->gen.skip_verbs = 1; /* applied in below */ > snd_hda_gen_init(codec); > alc_fix_pll(codec); > -- > 2.25.1 >