From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22E29C43334 for ; Wed, 8 Jun 2022 05:40:05 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6493717B2; Wed, 8 Jun 2022 07:39:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6493717B2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1654666803; bh=VgmuqYIUaiUTx+s9FVQaH6hlZfd5pbjbOdNDqby/2hQ=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BC/irmf1EnlKb4UiBG5G1zV49rwM6c0jWbBFWdl69lGLdA6r4OWnQLXOxMhIcogyJ C+i1aSpJ/R0ig6mGVX4BSHu5WDuebR/vzp1AAa8yo2SuqTRS46VI9S7kKVZ6lBgG+X BxMO6p5nwBzcWa52qnX4X1WxhgdvRLEp6GVGffxE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 06A3CF80116; Wed, 8 Jun 2022 07:39:13 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4179BF8024C; Wed, 8 Jun 2022 07:39:11 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 736EFF80116 for ; Wed, 8 Jun 2022 07:39:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 736EFF80116 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="X5Bb6ThA"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="VyiFuKAG" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1B7C31F8E2; Wed, 8 Jun 2022 05:39:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1654666743; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3mZ/PXfjVKtorPmVsSMY5YoBOKNZzD+HSU3DLcMJGYY=; b=X5Bb6ThAXhKHsAUr59jwzgmqfC5U2RHTqUtgVOilgFGzAYWGRKHSuda7zVXCLaLILExOmq /EKYkR4p98z2+8F8eL124XgYY1asa158JycyWJdY2BDUiYERZWeF32h5gKad/ky7bBu/2R IUQnNAkpIkgROXf6y2xAMAM+HTjkdCE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1654666743; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3mZ/PXfjVKtorPmVsSMY5YoBOKNZzD+HSU3DLcMJGYY=; b=VyiFuKAGH1WQ0h4f49zhQq3wnRT/jofAXWxKJ9OHU8T6F5AzGnTMXoltjYm9Rsfz7nNwI1 VGmKjTDtU4EVvpBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D48C713638; Wed, 8 Jun 2022 05:39:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id TtSxMvY1oGJzcAAAMHmgww (envelope-from ); Wed, 08 Jun 2022 05:39:02 +0000 Date: Wed, 08 Jun 2022 07:39:02 +0200 Message-ID: <877d5rd895.wl-tiwai@suse.de> From: Takashi Iwai To: huangwenhui Subject: Re: [PATCH] ALSA: hda/realtek - Add HW8326 support In-Reply-To: <20220608011227.15994-1-huangwenhuia@uniontech.com> References: <20220608011227.15994-1-huangwenhuia@uniontech.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, kailang@realtek.com, tanureal@opensource.cirrus.com, jeremy.szu@canonical.com, linux-kernel@vger.kernel.org, tiwai@suse.com, wse@tuxedocomputers.com, hui.wang@canonical.com, sami@loone.fi, cam@neo-zeon.de X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 08 Jun 2022 03:12:27 +0200, huangwenhui wrote: > > Added the support of new Huawei codec HW8326. > > Signed-off-by: huangwenhui Please give more description, as mentioned in the previous post, but *in the patch itself*. If it's compatible with the existing ALC256, describe it there. Also, when you post a newer version of the patch, add v2 prefix to the subject, e.g. [PATCH v2] ALSA: hda/realtek - Add HW8326 support (Of course at the next respin, it'll be v3 :) thanks, Takashi