From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH 06/19] ASoC: rsnd: add .set_sysclk on
	snd_soc_dai_ops
Date: Sun, 02 Mar 2014 18:08:00 -0800 (PST)
Message-ID: <877g8cxcea.wl%kuninori.morimoto.gx@gmail.com>
References: <87d2ib90t9.wl%kuninori.morimoto.gx@gmail.com>
 <874n3n90qt.wl%kuninori.morimoto.gx@gmail.com>
 <20140303011844.GA2411@sirena.org.uk>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mail-pb0-f52.google.com (mail-pb0-f52.google.com
 [209.85.160.52])
 by alsa0.perex.cz (Postfix) with ESMTP id 7B7362654D3
 for <alsa-devel@alsa-project.org>; Mon,  3 Mar 2014 03:08:02 +0100 (CET)
Received: by mail-pb0-f52.google.com with SMTP id rr13so3097666pbb.25
 for <alsa-devel@alsa-project.org>; Sun, 02 Mar 2014 18:08:01 -0800 (PST)
In-Reply-To: <20140303011844.GA2411@sirena.org.uk>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>, Simon <horms@verge.net.au>, Liam Girdwood <lgirdwood@gmail.com>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
List-Id: alsa-devel@alsa-project.org


Hi Mark

> > This patch adds struct snd_soc_dai_ops :: set_sysclk.
> > But, it do nothing, since rsnd sysclk is controlled by ADG.
> > Without this patch, simple-card init will be failed
> > if DT case.
> 
> We should fix the simple-card code so that it does not need this rather
> than adding empty functions to all the drivers - I'd expect it to handle
> -ENOTSUPP as not an error.

Ahh...

Current simple-card will get sysclk absolutely in normal (?) way.
Can you see end of asoc_simple_card_sub_parse_of() ?

rsnd got sysclk from it, but it is "module" clock, not "sysclk".

I guess I can avoid this issue if dtsi has

	system-clock-frequency = 0;

but it is strange.