From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1169BC25B67 for ; Fri, 27 Oct 2023 10:35:36 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 67880AE9; Fri, 27 Oct 2023 12:34:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 67880AE9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1698402934; bh=15KNZnmcVkibTtn0X+sFaZtV6SKfDLgyWFZkhqPRhw0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=FxVgOAPOUz4wrYj1DWtTxvfuzhwW4uDJu+jcZdK5utCJRrEo641ZnsSbxeDmXXX+u d3eqxs8jiRtm/vDUfeKQwqBVPcEwmfiXe8RigdJ1oRl+0f6OSVUyhkrFImsA6R7Eil Qt1/SHoV6ekm0Im/rIpC+FhZdI0Bu2TgkECRTw2c= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 918E9F8019B; Fri, 27 Oct 2023 12:34:43 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 211BCF8019B; Fri, 27 Oct 2023 12:34:43 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C831BF8019B; Fri, 27 Oct 2023 12:34:37 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A6F64F8012B for ; Fri, 27 Oct 2023 12:34:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A6F64F8012B Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=CIBAc3x7; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=NY5QUAYc Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D450521AFB; Fri, 27 Oct 2023 10:34:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1698402868; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pXB1Vb14kOU6d7gNmdGMsie6xUdluembpQff2Dnn5NA=; b=CIBAc3x7bxs3JxiE36WwJlnpyCWOXUoyUp+EAEmUwWt66TNEi4GisgvR/BexJ/joYMQqc8 BnqQiFHOqndPNTXgzRAVxl/W52Q9V70JoRzWy8W5ApsiQQdhu86mh3DCuTHgvvovmThdDN a8dHmypELKhkoZJLE0m4Lyi73YldlQg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1698402868; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pXB1Vb14kOU6d7gNmdGMsie6xUdluembpQff2Dnn5NA=; b=NY5QUAYcFlBwLvrvzA4kEf81jAczgh4JM8aol88L9dvTpX0rfY5Fnx9z0lgAXeYiUlacjR Dij5PxynofHfFRDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AB5FC1358C; Fri, 27 Oct 2023 10:34:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Lx7EKDSSO2VDfgAAMHmgww (envelope-from ); Fri, 27 Oct 2023 10:34:28 +0000 Date: Fri, 27 Oct 2023 12:34:29 +0200 Message-ID: <878r7oxsju.wl-tiwai@suse.de> From: Takashi Iwai To: "Geoffrey D. Bennett" Cc: Takashi Iwai , alsa-devel@alsa-project.org Subject: Re: [PATCH] ALSA: scarlett2: Add missing check with firmware version control In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-10.09 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-3.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-2.99)[99.96%] Message-ID-Hash: OUQQJZ72P3CHJT4FKKOX6DTCWMWDB5IB X-Message-ID-Hash: OUQQJZ72P3CHJT4FKKOX6DTCWMWDB5IB X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 27 Oct 2023 12:01:21 +0200, Geoffrey D. Bennett wrote: > > scarlett2_add_firmware_version_ctl() may return an error, but the > return value was not being checked. Add the missing check. > > Signed-off-by: Geoffrey D. Bennett Thanks, applied with Fixes tag. Takashi