From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8091C77B75 for ; Mon, 8 May 2023 07:15:34 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A7BE112A6; Mon, 8 May 2023 09:14:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A7BE112A6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683530132; bh=ZZJPf8r0Dc0BA1jSWlJV9lwPpg9t9s6IbMReelbNP5s=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=fbtINMMuOfJBrvLu0RR3sAWw60XsqSYIStX6dPZSDgjzy5YDwpaOSSGqoAaK4wEYF m2/k7wkAqybLkkNQTjpk5OL3uD/SY+9wk0a1t2ENlu5aWUGeO50QiEw7zVMtyJnow8 YXYeGUvfVmLgOQx8hE1nOaXdwCXEVF1NUYorlHCI= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 46936F8032D; Mon, 8 May 2023 09:14:17 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DF1F1F8032D; Mon, 8 May 2023 09:14:12 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 65FCFF80087 for ; Mon, 8 May 2023 09:14:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 65FCFF80087 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MwXiYZ1b; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=yxVeGMw7 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6CAB221B66; Mon, 8 May 2023 07:14:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683530042; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EyknMMdMLlIoJXWiRlmJ/7tqeFXWKoGEexP23LwhMK0=; b=MwXiYZ1bb/fzec5ugdpDqmbLBL5n7VkyYgzO4qzJbxEd6czTFXHCf27DiGfoe2ENtngij9 kIq4LLul+ipGg9pwgzGFbliT9RNbBqNKeg6xL3W/uuaQExH8agA8piw49qF/Y9Kp5beqwJ fGg0q24LfC+72PQ6Jkz3VQcR5zSFB/k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683530042; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EyknMMdMLlIoJXWiRlmJ/7tqeFXWKoGEexP23LwhMK0=; b=yxVeGMw71Awc/oO3dRF+UAt2tekQn54jFgyi2AvCI0ZoSnw72PZi6SNohpG7kRP6XSdm1z obITQCNuR7yPTTCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4A8151346B; Mon, 8 May 2023 07:14:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id imcMETqhWGTuLQAAMHmgww (envelope-from ); Mon, 08 May 2023 07:14:02 +0000 Date: Mon, 08 May 2023 09:14:01 +0200 Message-ID: <878rdzfg7a.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH] ALSA: emu10k1: macro-ize snd_emu10k1_ptr_{read,write}() In-Reply-To: <20230428095941.1706263-1-oswald.buddenhagen@gmx.de> References: <20230428095941.1706263-1-oswald.buddenhagen@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: ULS2LTUBZBLL22KGZSF3T6EXZFF4DSJW X-Message-ID-Hash: ULS2LTUBZBLL22KGZSF3T6EXZFF4DSJW X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 28 Apr 2023 11:59:41 +0200, Oswald Buddenhagen wrote: > +#define snd_emu10k1_ptr_read(emu, reg, voice) \ > + ({ \ > + u32 data = snd_emu10k1_ptr_read_raw(emu, REG_ADDR(reg, voice)); \ > + if (REG_SIZE(reg)) \ > + data = REG_VAL_GET(reg, data); \ > + data; \ > + }) > +#define snd_emu10k1_ptr_write(emu, reg, voice, data) \ > + do { \ > + if (REG_SIZE(reg)) \ > + snd_emu10k1_ptr_modify(emu, REG_ADDR(reg, voice), \ > + ~REG_MASK(reg), REG_VAL_PUT(reg, data)); \ > + else \ > + snd_emu10k1_ptr_write_raw(emu, REG_ADDR(reg, voice), data); \ > + } while (0) Must those be macros? Not only that macro isn't really safe to use for obvious reasons, the expansion would cost significantly as they are called in many places. > --- a/sound/pci/emu10k1/io.c > +++ b/sound/pci/emu10k1/io.c > @@ -18,72 +18,64 @@ > #include > #include "p17v.h" > > -unsigned int snd_emu10k1_ptr_read(struct snd_emu10k1 * emu, unsigned int reg, unsigned int chn) > +static inline int check_ptr_reg(struct snd_emu10k1 *emu, u32 reg) Should be bool. thanks, Takashi