From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE14CC77B73 for ; Sun, 23 Apr 2023 07:29:07 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4D0A7F1B; Sun, 23 Apr 2023 09:28:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4D0A7F1B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1682234944; bh=DR2GGs21KNmh/ZtNkVLVuIl5acwrLrQXKO9RzAc5fCI=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=jNvfZtbojR08zm8YrInmS50UgEukAHFI+E333Z+BevTw1x0avcytradkxqKtzDrP9 nTtRQPNsHGcSpYMaSDLMesDhrVRCJixlCnBKRpaZIN/nelsH3MmtM/qsxE5RSfUB4h 1S3/Ks1SJ3Sxt4MpGiFwzK3OOuMhDVm738frFYNU= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 23B80F80236; Sun, 23 Apr 2023 09:27:45 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 53524F80236; Sun, 23 Apr 2023 09:26:09 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E4E03F80137 for ; Sun, 23 Apr 2023 09:25:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E4E03F80137 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=mFOa4AOs; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=NGrBgM1B Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 46CAB1F8BD; Sun, 23 Apr 2023 07:25:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682234740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SEzjrY+HYPO7BOZUSWp3EA+HeQXJV3vHtGcuQltrbak=; b=mFOa4AOsN7nFzykbW9AKLgt2QtFz91Kx5WfGvTPd4iNzl7NS5xcWQu+88lXVJw0V9xoHL/ ySLN1kFXBKzr0SmBC7rT+fX070pyas0VdyUjsNva2fWmWzeeelE6akDO7aXNz5dmCMdDpc 0waP9SMmemR7bP08NGhRHbqLbx6nhnI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682234740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SEzjrY+HYPO7BOZUSWp3EA+HeQXJV3vHtGcuQltrbak=; b=NGrBgM1BcnZ8M0ZfcT/XG1sQjnIuOTU7b1drCaMjkQPXyV47lQvQx2YBGp0Sr18DXEUIxl Hht6OBmT5349yhAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1FBCA13498; Sun, 23 Apr 2023 07:25:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4JCtBnTdRGSmLwAAMHmgww (envelope-from ); Sun, 23 Apr 2023 07:25:40 +0000 Date: Sun, 23 Apr 2023 09:25:39 +0200 Message-ID: <878rejoya4.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH 2/2] ALSA: emu10k1: use high-level I/O in set_filterQ() In-Reply-To: <20230422161021.1143967-2-oswald.buddenhagen@gmx.de> References: <20230422161021.1143967-1-oswald.buddenhagen@gmx.de> <20230422161021.1143967-2-oswald.buddenhagen@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: C4Q73PAVVNOF4E6AHVTWIMM6SB43YVYU X-Message-ID-Hash: C4Q73PAVVNOF4E6AHVTWIMM6SB43YVYU X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sat, 22 Apr 2023 18:10:21 +0200, Oswald Buddenhagen wrote: > > Signed-off-by: Oswald Buddenhagen Again, you must have a bit more say here... For example, you didn't write why this change is needed. You thought it obvious? No, readers don't know. BTW, it would be really better if we define some macro for the highlevel I/O definition. It's cumbersome to decode and check manually at review whether the conversion is correct, and it's error-prone. thanks, Takashi