From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF84BC7618D for ; Thu, 6 Apr 2023 14:55:04 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8D175ED6; Thu, 6 Apr 2023 16:54:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8D175ED6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1680792902; bh=NbFh4VsfBCR1VOhwyuL4rllODSvMjtWBuMrplPeFMnM=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=n3z5VSvQ8wjNoMmU7wdLiMZSvDtRZOODOndN1cBFjTMBgWOidj9fbdlieWZ3KUoJX DWwLCi7v2bNQGo+ukmt/bpQncAp65dTMlaZ9X5FDsscdn4AAU2TD3RYlYVHR18dpvg nXyFKcuF4W2Amw+5/Dtegqu6itdjFIf+BIGBebtk= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id ED1FAF80149; Thu, 6 Apr 2023 16:53:49 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 40626F80246; Thu, 6 Apr 2023 16:53:47 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7B78CF8013D for ; Thu, 6 Apr 2023 16:53:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7B78CF8013D Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=dxfqEDH4; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IUawN+9h Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F0CD922764; Thu, 6 Apr 2023 14:53:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1680792824; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=75kRHtI7TGPSfEtRS6w3OZz2fIzPjdexrtIVHLpZNEQ=; b=dxfqEDH4qA58MsvDO5pPluV/UWAZVJOpeAWyvqTHcCkWmST3D2/aaMmZWF6yTfvWQqVycF u3YsiJzJyO+EGShR4t76cMKrqMrA8+s/WXnBdsdwpXNiDqkP0CYhpRo/QtBQyZ401C7ghC 4sUPo/yFGvZxeGLd7VId9DGGCNRwq+Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1680792824; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=75kRHtI7TGPSfEtRS6w3OZz2fIzPjdexrtIVHLpZNEQ=; b=IUawN+9hQsRZLIelsM9+yonogHI3mpYgK7ZdH7aoQlg4AvfvOYM/CSa0rPa7asDCJ88wwn QdHhFs9sXfqSOgBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DBB481351F; Thu, 6 Apr 2023 14:53:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fA/0NPjcLmRaOwAAMHmgww (envelope-from ); Thu, 06 Apr 2023 14:53:44 +0000 Date: Thu, 06 Apr 2023 16:53:44 +0200 Message-ID: <878rf5t62v.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH 1/2] ALSA: pcm: rewrite snd_pcm_playback_silence() In-Reply-To: <20230405201219.2197789-1-oswald.buddenhagen@gmx.de> References: <20230405201219.2197789-1-oswald.buddenhagen@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: L73Q6U65L2GBN5OT2VY4QQWMZY3NGD6C X-Message-ID-Hash: L73Q6U65L2GBN5OT2VY4QQWMZY3NGD6C X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 05 Apr 2023 22:12:18 +0200, Oswald Buddenhagen wrote: > > The auto-silencer supports two modes: "thresholded" to fill up "just > enough", and "top-up" to fill up "as much as possible". The two modes > used rather distinct code paths, which this patch unifies. The only > remaining distinction is how much we actually want to fill. > > This fixes a bug in thresholded mode, where we failed to use new_hw_ptr, > resulting in under-fill. > > Top-up mode is now more well-behaved and much easier to understand in > corner cases. > > This also updates comments in the proximity of silencing-related data > structures. > > Signed-off-by: Oswald Buddenhagen Applied both patches now to for-next branch. thanks, Takashi