From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F2F5C3271F for ; Thu, 4 Jul 2024 16:37:37 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 66B4E14DD; Thu, 4 Jul 2024 18:37:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 66B4E14DD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1720111054; bh=EiA/v4F0VT72IMcBI1FELFK81jVfjBduXmorIXbUuG8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=oEhD2uwrmfWjpX552jrGDX72oQEoDHFKRjFbD0G74D0r732Y2N49Xx/cYyOQZ8LuC sG6mGC8vL1T/l/J22wWq8v6bbn8YrKHZayrGWVGbLK4mp/ewiWd0DU19jBKpH9ykTE rqkfL8cPgRFKXXC1YjRmg721mWncO7D6n4dErFKU= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3162AF805AB; Thu, 4 Jul 2024 18:37:03 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 9C494F805B1; Thu, 4 Jul 2024 18:37:01 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5C333F8025E; Thu, 4 Jul 2024 18:31:46 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C69B4F800FE for ; Thu, 4 Jul 2024 18:31:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C69B4F800FE Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tid5cHsG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=WZYhdwZW; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tid5cHsG; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=WZYhdwZW Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C963E21C0D; Thu, 4 Jul 2024 16:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1720110692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xLNUadJNZq9PBVkZVV3qA+8WFad1SXcKhuECQEgP8BY=; b=tid5cHsGYvmN4PSAMWlLRMbGaDo5klxNRBF7CdDT2qCDynEMZxdJTnhzhpd6ZPWG8AADx6 hljNGOVfRnUWfjlryZ1yIabnWXIIVrfdINMTK0jf8q4slb8Z/xkCh69iHsePgYXxOxrpvy nAazn5uNSc/9MgLytzYImSykJQWHAaA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1720110692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xLNUadJNZq9PBVkZVV3qA+8WFad1SXcKhuECQEgP8BY=; b=WZYhdwZWU75JXTWYKaX75oS9HJ5zmXhz+ZOVSMa/mZgTxpjCCGycf9RSGtjD/dJ68eICNq /MmVsgnWJ4feV2AQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1720110692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xLNUadJNZq9PBVkZVV3qA+8WFad1SXcKhuECQEgP8BY=; b=tid5cHsGYvmN4PSAMWlLRMbGaDo5klxNRBF7CdDT2qCDynEMZxdJTnhzhpd6ZPWG8AADx6 hljNGOVfRnUWfjlryZ1yIabnWXIIVrfdINMTK0jf8q4slb8Z/xkCh69iHsePgYXxOxrpvy nAazn5uNSc/9MgLytzYImSykJQWHAaA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1720110692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xLNUadJNZq9PBVkZVV3qA+8WFad1SXcKhuECQEgP8BY=; b=WZYhdwZWU75JXTWYKaX75oS9HJ5zmXhz+ZOVSMa/mZgTxpjCCGycf9RSGtjD/dJ68eICNq /MmVsgnWJ4feV2AQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9D3CB13889; Thu, 4 Jul 2024 16:31:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id f5UOJWTOhma+UwAAD6G6ig (envelope-from ); Thu, 04 Jul 2024 16:31:32 +0000 Date: Thu, 04 Jul 2024 18:32:02 +0200 Message-ID: <87a5ixi0e5.wl-tiwai@suse.de> From: Takashi Iwai To: MadEnvel Cc: tiwai@suse.com, rf@opensource.cirrus.com, david.rhodes@cirrus.com, alsa-devel@alsa-project.org, patches@opensource.cirrus.com Subject: Re: [PATCH 1/1] Fix swapped left and right channels for Lenovo ThinBook 13x Gen4 sound In-Reply-To: <20240701205516.22662-2-envelsavinds@gmail.com> References: <20240701205516.22662-1-envelsavinds@gmail.com> <20240701205516.22662-2-envelsavinds@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spamd-Result: default: False [-3.24 / 50.00]; BAYES_HAM(-2.94)[99.74%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; FREEMAIL_TO(0.00)[gmail.com]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo] Message-ID-Hash: QKFJZZ4WB653YZD6SRU4SGWKMO3EEBEM X-Message-ID-Hash: QKFJZZ4WB653YZD6SRU4SGWKMO3EEBEM X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 01 Jul 2024 22:55:16 +0200, MadEnvel wrote: > > Signed-off-by: MadEnvel The Signed-off-by tag has to be a real name for legal reasons. Also, the empty patch description is always bad. Could you fill more information here, as such found in your cover letter? After correcting those, please resubmit (with Stefan's Reviewed-by tag added). Thanks! Takashi > --- > sound/pci/hda/cs35l41_hda_property.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c > index 51998d1c72ff..80c816922f78 100644 > --- a/sound/pci/hda/cs35l41_hda_property.c > +++ b/sound/pci/hda/cs35l41_hda_property.c > @@ -128,8 +128,8 @@ static const struct cs35l41_config cs35l41_config_table[] = { > { "17AA38B5", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 }, > { "17AA38B6", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 }, > { "17AA38B7", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 }, > - { "17AA38C7", 4, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT }, 0, 2, -1, 1000, 4500, 24 }, > - { "17AA38C8", 4, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT }, 0, 2, -1, 1000, 4500, 24 }, > + { "17AA38C7", 4, INTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT }, 0, 2, -1, 1000, 4500, 24 }, > + { "17AA38C8", 4, INTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT }, 0, 2, -1, 1000, 4500, 24 }, > { "17AA38F9", 2, EXTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, 0, 0 }, 0, 2, -1, 0, 0, 0 }, > { "17AA38FA", 2, EXTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, 0, 0 }, 0, 2, -1, 0, 0, 0 }, > {} > -- > 2.45.2 >