From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25B4AC0015E for ; Wed, 5 Jul 2023 08:57:13 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 20C8D83E; Wed, 5 Jul 2023 10:56:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 20C8D83E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1688547431; bh=hWj85RnTwj8Yfw0b6a4VFE+k4bJTlETMPKn2gxNA2Sc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=qQdsvH76M2q/J1yWNne5fDsIo/eeoNTL2ky0WFk+6BTUdkoyXrJd4mZHhDQmerBKy Gw3DTPeCPNFK/QYV+jb1cpo91kA5K0TeeEjPtET+kqPe8fQrfoBr3DQWJFRZ/SjMcr OIa31zVl7t5JJIscKXNmTeYGg0gzNiOhA6ZwSYYw= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0FB2BF8025F; Wed, 5 Jul 2023 10:55:49 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 99B63F80125; Wed, 5 Jul 2023 10:55:49 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A7757F80125; Wed, 5 Jul 2023 10:55:45 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0C4E2F80100 for ; Wed, 5 Jul 2023 10:55:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0C4E2F80100 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pHWlUw1n; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=DmtXsj4z Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AE0DD1F890; Wed, 5 Jul 2023 08:55:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1688547337; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eOmyEHyr0iiLqxM6ByyiTsEOHbd3rdaDe+tLZlMSH6U=; b=pHWlUw1nB4HYwtHIKr0PUn2rqxsjFSE0f3F8ydhxzB1QeKnkTRzRDN7sANSCxHOVYJ7cux Qwt8MaBUPXiDd4Y3FWMdRJQaluoLXy23zatuvkrzMdQ/Us+6O4j4aVdRQGUwtZgZ906LNd JpuQAuvakBrf6yH6Q0HTHtHfN1IckM4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1688547337; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eOmyEHyr0iiLqxM6ByyiTsEOHbd3rdaDe+tLZlMSH6U=; b=DmtXsj4z6R79cwOUnGi7y4vW3e0vTePbBmW0KSucdooEi3NIrfGlfEYw9Tls9ie7/NKO0d obFcaQK0WXRn2MCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 78692134F3; Wed, 5 Jul 2023 08:55:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WsN6HAkwpWRAXAAAMHmgww (envelope-from ); Wed, 05 Jul 2023 08:55:37 +0000 Date: Wed, 05 Jul 2023 10:55:37 +0200 Message-ID: <87a5waohyu.wl-tiwai@suse.de> From: Takashi Iwai To: Minjie Du Cc: Jaroslav Kysela , Takashi Iwai , Stephen Rothwell , alsa-devel@alsa-project.org (moderated list:SOUND), linux-kernel@vger.kernel.org (open list), opensource.kernel@vivo.com Subject: Re: [PATCH v1] sound: seq: check struct system assignment problem In-Reply-To: <20230705085022.13078-1-duminjie@vivo.com> References: <20230705085022.13078-1-duminjie@vivo.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: QNHTTBQOZRK2XOZIZ43JYC2NL2BMPXWU X-Message-ID-Hash: QNHTTBQOZRK2XOZIZ43JYC2NL2BMPXWU X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 05 Jul 2023 10:50:22 +0200, Minjie Du wrote: > > make data->system.parm1 avoid double assignment. > but note writes "RT message with two parameters to UMP" > is one of assignment is for system.parm2? Yes, that should be rather parm2. Could you resubmit with that typo fix instead? Thanks! Takashi > I'm not sure, Could you help check it out? > Thank you! > > > Signed-off-by: Minjie Du > --- > sound/core/seq/seq_ump_convert.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/core/seq/seq_ump_convert.c b/sound/core/seq/seq_ump_convert.c > index eb1d86ff6..60e637149 100644 > --- a/sound/core/seq/seq_ump_convert.c > +++ b/sound/core/seq/seq_ump_convert.c > @@ -713,7 +713,6 @@ static int system_2p_ev_to_ump_midi1(const struct snd_seq_event *event, > unsigned char status) > { > data->system.status = status; > - data->system.parm1 = (event->data.control.value >> 7) & 0x7f; > data->system.parm1 = event->data.control.value & 0x7f; > return 1; > } > -- > 2.39.0 >