From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF07EC77B7C for ; Thu, 4 May 2023 08:19:48 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5860E18F1; Thu, 4 May 2023 10:18:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5860E18F1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683188386; bh=SIBoVqI5PkWzf5aqNZbQCNSoVU3MrLjwI7ojaRY+mmE=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Q/m6Z2OQ99mYWFKrUkQiLWyvT42+bVAy6PSxORi5bBrtvd71oBnoO6qFijYOiy2IT xvhU/leBNhBPEoCbA+pWL7CbNtJGrh3aqfN/y+jBr3Crj/IhQRUk++cgvVcmxJ1n0U hjVHkBMtitBrEOKRXeE0ETl6QQGHLCYNBXSBd8Tw= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 43E8BF8052D; Thu, 4 May 2023 10:18:31 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6EC89F8052D; Thu, 4 May 2023 10:18:27 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 07D6EF804B1 for ; Thu, 4 May 2023 10:18:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 07D6EF804B1 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=J5vdzE5m; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YvYYbbyU Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5D26B338EE; Thu, 4 May 2023 08:18:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683188297; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EG1xCOtQvBClgCA9n2ZNiUvXovCTbSuSFN18i+Fws9g=; b=J5vdzE5mVa1c9i9WNX7q8jKeyROADzw977wCvZVkYCvdPqXJqmFItBVngU3/Btj4zdg3Uq ESr7JGLjUdUOxK2xlIwgXK0gV8yQojGYL8YC6GzVG6cHhrdwaNt0jg6JPRpF/ts7SXdIO6 VhLw4MUYNlWhJGURmbek60dXv+7vwsM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683188297; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EG1xCOtQvBClgCA9n2ZNiUvXovCTbSuSFN18i+Fws9g=; b=YvYYbbyU2M92nma0elUbPA12YK+CzneXa1rhIFU0woMqrsOu+huFWP5FhEVGAKZKy4sdDS XwcX9Q4ScdiOAuAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3FA40133F7; Thu, 4 May 2023 08:18:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Yne4DklqU2TQMAAAMHmgww (envelope-from ); Thu, 04 May 2023 08:18:17 +0000 Date: Thu, 04 May 2023 10:18:16 +0200 Message-ID: <87a5ykmrw7.wl-tiwai@suse.de> From: Takashi Iwai To: Jaroslav Kysela Subject: Re: [PATCH alsa-lib 3/4] pcm: hw: introduce SNDRV_PCM_INFO_PERFECT_DRAIN In-Reply-To: <20230502115010.986325-4-perex@perex.cz> References: <20230502115010.986325-1-perex@perex.cz> <20230502115010.986325-4-perex@perex.cz> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: FYG6J5G7J4BU7YKQ5EV25GKWPLH7AT5Y X-Message-ID-Hash: FYG6J5G7J4BU7YKQ5EV25GKWPLH7AT5Y X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: ALSA development X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 02 May 2023 13:50:09 +0200, Jaroslav Kysela wrote: > > The driver may not require to touch the sample stream > for the drain operation at all. Handle this situation > in alsa-lib. > > Signed-off-by: Jaroslav Kysela Ideally speaking, the checks and the setups of those new bits should be coupled with the PCM protocol version check (and the version bump). But it seems that you've already applied the series, and practically seen, those bits should be either not set or harmless, so let's cross fingers. thanks, Takashi