From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D900C05027 for ; Wed, 1 Feb 2023 12:13:32 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 50B57203; Wed, 1 Feb 2023 13:12:39 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 50B57203 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1675253609; bh=cvV4n3AMccS0dEjXyasCg7taHlejGkGoiM9PoEm4WqU=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=J8SZc1EktwmJlvpVkLU+MOkMF1/JfE/ofES3KrdVmHNHQeC3qJc2EFYNPJUHacigM RtliTmmjQoooMARL9qfBe+403ySvop4CsDQMqcbAVR0n3BZ9B+8MCydS76meYKapXN YM9nQBsPSmrmQQZh1moS2PKe14BeqfuLtMhZDdws= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C443FF80169; Wed, 1 Feb 2023 13:12:38 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2A219F80423; Wed, 1 Feb 2023 13:12:38 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 96D23F80169 for ; Wed, 1 Feb 2023 13:12:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 96D23F80169 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=aMZ6tlcY; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=vfNYhiOU Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 41D3B20DA6; Wed, 1 Feb 2023 12:12:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675253549; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hskn5wbLCyMCr9B8BR8CQUkQzxcpqNiKf8xyLuw6SZE=; b=aMZ6tlcYqeCBSkH9uqfQ7T78seVdU5VNY0rue/rpNAiMRKbhWeDFP1Gx7+3CCxwmCFugrn ATmqBntDf2URpHP3hhDBGg/CRslPzkPGamiGr6aNSdK43Q/fn7+C7S3rKpU8ZklP/nu/2N 1ZLfkJB+eCBR10dCg6zmGw2vDmO00jA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675253549; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hskn5wbLCyMCr9B8BR8CQUkQzxcpqNiKf8xyLuw6SZE=; b=vfNYhiOUFhufPJ5hpWo8f58YHFOOnre+8rJHdG6D58eJRZ6WpqJ2bdz+Kjz3TYaApD5xOM pub6cdoVOn3w8MDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 321921348C; Wed, 1 Feb 2023 12:12:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lkrtCy1X2mPrMwAAMHmgww (envelope-from ); Wed, 01 Feb 2023 12:12:29 +0000 Date: Wed, 01 Feb 2023 13:12:28 +0100 Message-ID: <87a61xy47n.wl-tiwai@suse.de> From: Takashi Iwai To: Jiapeng Chong Subject: Re: [PATCH] ALSA: emu10k1: clean up some inconsistent indenting In-Reply-To: <20230131084304.12920-1-jiapeng.chong@linux.alibaba.com> References: <20230131084304.12920-1-jiapeng.chong@linux.alibaba.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Abaci Robot , tiwai@suse.com Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 31 Jan 2023 09:43:04 +0100, Jiapeng Chong wrote: > > No functional modification involved. > > sound/pci/emu10k1/memory.c:446 snd_emu10k1_synth_free() warn: inconsistent indenting. How is this warning generated? Does it come from clang or any other compiler, or is it just some tool? In general, I take such a white-space-fix-only patch when it's tied with other real fix patches. But if the compiler warns, it's worth to pick up, of course. thanks, Takashi > > Reported-by: Abaci Robot > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3903 > Signed-off-by: Jiapeng Chong > --- > sound/pci/emu10k1/memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/emu10k1/memory.c b/sound/pci/emu10k1/memory.c > index edb3f1763719..6a7406014f81 100644 > --- a/sound/pci/emu10k1/memory.c > +++ b/sound/pci/emu10k1/memory.c > @@ -443,7 +443,7 @@ snd_emu10k1_synth_free(struct snd_emu10k1 *emu, struct snd_util_memblk *memblk) > unmap_memblk(emu, blk); > spin_unlock_irqrestore(&emu->memblk_lock, flags); > synth_free_pages(emu, blk); > - __snd_util_mem_free(hdr, memblk); > + __snd_util_mem_free(hdr, memblk); > mutex_unlock(&hdr->block_mutex); > return 0; > } > -- > 2.20.1.7.g153144c >