From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11C0FC54EBD for ; Fri, 13 Jan 2023 08:57:06 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1A923A411; Fri, 13 Jan 2023 09:56:15 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1A923A411 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1673600225; bh=AvIR02/8LDo5rNf1iZNMXQX6krLeGFcu/JowYUtgiYE=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=tK3C10nUncIUdImvqSFFjZf2M89U8jjNXnjM5kAM6RNnE20Npo2yXPX2ap0lPPSCs eB1YWGb6Ygdsu0OVPgvlFmZ9RI7xH+7BkAa5F2BwKsMliWFDhaQ6sQyfNParO2eIDE G/1/SNFNMz6MNhwu3p8r3eApw2qP/vP8XIAjvxAk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C764FF802E8; Fri, 13 Jan 2023 09:56:14 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4A74EF8030F; Fri, 13 Jan 2023 09:56:13 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5F6F7F8016D for ; Fri, 13 Jan 2023 09:56:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5F6F7F8016D Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xB/C/K6z; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=xApzkJRX Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C2B916001F; Fri, 13 Jan 2023 08:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1673600170; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eKDD9yGJA4YbHAwlzIibj028FXua1+RGJ9fxcwqwHWc=; b=xB/C/K6zY2Llgtj4k7xKFyRYVgMVv8ptdvz82ipJmZDZDqSpzVPu8zVrakVr8RS7VLPgt7 mrVtSpXtPsEcCX8ZyxNUB8iu80kG8f7wOnQ6FqruBCx8wg80ia6i4m7blbe029qZVQog9y FD+v9uRfSfcRMm2GwIryflE1rYrp4vg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1673600170; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eKDD9yGJA4YbHAwlzIibj028FXua1+RGJ9fxcwqwHWc=; b=xApzkJRXyRSgxQelKNJyklqkCgt85E9XT9tG7L4u+d3yIdxbagdEjYEDAhL82QNMPHm1cX q+4XSmJoY0zkDyBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A3DEA1358A; Fri, 13 Jan 2023 08:56:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YncsJ6ocwWPtYwAAMHmgww (envelope-from ); Fri, 13 Jan 2023 08:56:10 +0000 Date: Fri, 13 Jan 2023 09:56:10 +0100 Message-ID: <87a62m6cet.wl-tiwai@suse.de> From: Takashi Iwai To: Jaroslav Kysela Subject: Re: [PATCH] ALSA: usb-audio: Fix possible NULL pointer dereference in snd_usb_pcm_has_fixed_rate() In-Reply-To: <20230113085311.623325-1-perex@perex.cz> References: <20230113085311.623325-1-perex@perex.cz> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ALSA development , coverity-bot Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 13 Jan 2023 09:53:11 +0100, Jaroslav Kysela wrote: > > The subs function argument may be NULL, so do not use it before the NULL check. > > Fixes: 291e9da91403 ("ALSA: usb-audio: Always initialize fixed_rate in snd_usb_find_implicit_fb_sync_format()") > Reported-by: coverity-bot > Link: https://lore.kernel.org/alsa-devel/202301121424.4A79A485@keescook/ > Signed-off-by: Jaroslav Kysela Applied, thanks. Takashi