From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09449C433FE for ; Thu, 3 Nov 2022 08:00:06 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3808315C2; Thu, 3 Nov 2022 08:59:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3808315C2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1667462404; bh=ltIjS5u5NQ+OCpMo4Pd6HIDRZmYUD6536/5hzQTRyrw=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=QnPle7lIH5Na7cjAQ1/8l0l8nUbOvOqxXkDwuB0jRHyNjJFN5YIJRSzVkcjJ5E0nW mQgkU53PMHFejsHKYPJ21edMmM1M5Uw5Gl1uHFvjlydQSD7Vq9vcq/EUSd7uIKZ6N1 1ua1i07b5OlK6d5RPToy95UpxI2b9DQWkc0W2WmA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 999FFF8051E; Thu, 3 Nov 2022 08:59:13 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1996BF8051F; Thu, 3 Nov 2022 08:59:12 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2887BF800BF for ; Thu, 3 Nov 2022 08:59:04 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2887BF800BF Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="FHY1mHpX"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="emFsONiO" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 734611F9E5; Thu, 3 Nov 2022 07:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667462344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4H1fD4BTdPL3Y/bKoYtG9Wt8bt1+57sjE9PmOeD3ZMA=; b=FHY1mHpXOb0bwTvA4gRMa4e6kePExIGVbFE9Gr3gt1GsnhrENy4WU2mLbcAzUwttWBGtBI T1XgRguekNsB1WR200M2yqNcmzNdZIHNlg58Hw4jmdykkAlY5IsYTrH9TUt5rbLh3DhqB3 Cgszva6f4u97e4U5OHn+pk9aupTwm/o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667462344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4H1fD4BTdPL3Y/bKoYtG9Wt8bt1+57sjE9PmOeD3ZMA=; b=emFsONiOWem4PhqiCeT08Z97fLyU+icvC+EFrBybN+lGjoVACtg0fp0ImuZqvjqzkOhjLx nHIqVef6/keVd1Dg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3DF5F13AAF; Thu, 3 Nov 2022 07:59:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uZw2Dsh0Y2O2KwAAMHmgww (envelope-from ); Thu, 03 Nov 2022 07:59:04 +0000 Date: Thu, 03 Nov 2022 08:59:03 +0100 Message-ID: <87a658o4e0.wl-tiwai@suse.de> From: Takashi Iwai To: Pierre-Louis Bossart Subject: Re: [PATCH] Fix kbl_rt5663_rt5514_max98927 regression In-Reply-To: <2bbe7bed-21d4-018a-8957-10d9dbe0c661@linux.intel.com> References: <20221102200527.4174076-1-jmontleo@redhat.com> <2bbe7bed-21d4-018a-8957-10d9dbe0c661@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: oder_chiou@realtek.com, cezary.rojewski@intel.com, Charles Keepax , regressions@lists.linux.dev, Jason Montleon , alsa-devel@alsa-project.org, Takashi Iwai , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 02 Nov 2022 23:05:14 +0100, Pierre-Louis Bossart wrote: > > On 11/2/22 16:05, Jason Montleon wrote: > > Starting with 6.0-rc1 these messages are logged and the sound card > > is unavailable. Adding legacy_dai_naming to the rt5514-spi causes > > it to function properly again. > > > > [ 16.928454] kbl_r5514_5663_max kbl_r5514_5663_max: ASoC: CPU DAI > > spi-PRP0001:00 not registered > > [ 16.928561] platform kbl_r5514_5663_max: deferred probe pending > > Thanks for reporting this regression, much appreciated. > > a) you need to CC: maintainers Mark Brown and Takashi Iwai > b) the commit title should be something like "ASoC: rt5514: fix legacy > dai naming". > c) it's not clear if this is actually enough. there's no > legacy_dai_naming for e.g. rt5663 and the .endianness member is not set. IIUC, rt5663.c should be fine; it used to have non_legacy_dai_naming flag and it was dropped after the switch. But, through a quick glance, rt5677-spi.c seems to be the same pattern as rt5514-spi.c. The rt5677.c was covered properly but the *-spi.c wan't. Takashi > > Adding Charles Keepax for comments. > > > --- > > sound/soc/codecs/rt5514-spi.c | 15 ++++++++------- > > 1 file changed, 8 insertions(+), 7 deletions(-) > > > > diff --git a/sound/soc/codecs/rt5514-spi.c b/sound/soc/codecs/rt5514-spi.c > > index 1a25a3787935..362663abcb89 100644 > > --- a/sound/soc/codecs/rt5514-spi.c > > +++ b/sound/soc/codecs/rt5514-spi.c > > @@ -298,13 +298,14 @@ static int rt5514_spi_pcm_new(struct snd_soc_component *component, > > } > > > > static const struct snd_soc_component_driver rt5514_spi_component = { > > - .name = DRV_NAME, > > - .probe = rt5514_spi_pcm_probe, > > - .open = rt5514_spi_pcm_open, > > - .hw_params = rt5514_spi_hw_params, > > - .hw_free = rt5514_spi_hw_free, > > - .pointer = rt5514_spi_pcm_pointer, > > - .pcm_construct = rt5514_spi_pcm_new, > > + .name = DRV_NAME, > > + .probe = rt5514_spi_pcm_probe, > > + .open = rt5514_spi_pcm_open, > > + .hw_params = rt5514_spi_hw_params, > > + .hw_free = rt5514_spi_hw_free, > > + .pointer = rt5514_spi_pcm_pointer, > > + .pcm_construct = rt5514_spi_pcm_new, > > + .legacy_dai_naming = 1, > > }; > > > > /** >