From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH] ASoC: pxa: remove clock divider and pll setup from zylonite and magician Date: Sun, 15 Jul 2018 22:20:02 +0200 Message-ID: <87a7qs9rpp.fsf@belgarion.home> References: <20180713160717.4862-1-daniel@zonque.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.smtpout.orange.fr (smtp04.smtpout.orange.fr [80.12.242.126]) by alsa0.perex.cz (Postfix) with ESMTP id 039AF267600 for ; Sun, 15 Jul 2018 22:20:03 +0200 (CEST) In-Reply-To: <20180713160717.4862-1-daniel@zonque.org> (Daniel Mack's message of "Fri, 13 Jul 2018 18:07:17 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Daniel Mack Cc: alsa-devel@alsa-project.org, broonie@kernel.org, lgirdwood@gmail.com, haojian.zhuang@gmail.com List-Id: alsa-devel@alsa-project.org Daniel Mack writes: > The SSP DAI now handles the clocking setup itself, all it needs is the > master clock frequency. Remove the code from Zylonite and Magician > platforms. > > Signed-off-by: Daniel Mack > --- > sound/soc/pxa/magician.c | 105 +-------------------------------------- > sound/soc/pxa/zylonite.c | 9 ---- > 2 files changed, 1 insertion(+), 113 deletions(-) > > diff --git a/sound/soc/pxa/magician.c b/sound/soc/pxa/magician.c > index 2fc012b06c43..2746725a898c 100644 > --- a/sound/soc/pxa/magician.c > +++ b/sound/soc/pxa/magician.c > @@ -90,95 +90,9 @@ static int magician_playback_hw_params(struct snd_pcm_substream *substream, > struct snd_soc_pcm_runtime *rtd = substream->private_data; > struct snd_soc_dai *codec_dai = rtd->codec_dai; > struct snd_soc_dai *cpu_dai = rtd->cpu_dai; > - unsigned int acps, acds, width; > - unsigned int div4 = PXA_SSP_CLK_SCDB_4; > + unsigned int width; > int ret = 0; > > - width = snd_pcm_format_physical_width(params_format(params)); Ok so width is not initialized anymore ... Either it is used and an assignement should be there somewhere, or it is not used and the declaration is not necessary . Or width is assigned in a former patch I didn't apply and I don't see it in my branch ... Cheers. -- Robert