Re: [PATCH] ALSA: hda/realtek: Add quirk for HP Victus 15-fa2xxx

[Takashi Iwai <tiwai@suse.de>]

On Tue, 24 Mar 2026 23:25:03 +0100,
Dima Art wrote:
> 
> The HP Victus 15-fa2xxx (subsystem ID 103c:8dcd) uses two TAS2781
> amplifiers connected via I2C bus at addresses 0x36 and 0x37.
> Without this quirk, the amplifiers remain uninitialized causing
> mono audio output with no bass.
> 
> Tested on HP Victus 15-fa2xxx (HP-VictusbyHPGamingLaptop15_fa2xxx--8DCD)
> with kernel 6.19.0-9-generic on Ubuntu 26.04.
> 
> Signed-off-by: ardima93@gmail.com

The Signed-off-by line must be with a real name or a known identity,
as it's a legal requirement.

And, more importantly...

> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ alc269_fixup_tbl[] @@
> +    SND_PCI_QUIRK(0x103c, 0x8dcd, "HP Victus 15-fa2xxx",
> ALC245_FIXUP_TAS2781_I2C),

... the patch content itself looks broken, likely due to your mailer
setup.  Please try to fix it.

Also, for the kernel patch submission, please send to
linux-sound@vger.kernel.org instead of alsa-devel ML.
Last but not least, you shouldn't Cc to stable ML at posting, but put
Cc-to-stable around your signed-off-by tag in the patch description,
instead.


thanks,

Takashi