From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9690AC48BF6 for ; Thu, 7 Mar 2024 12:33:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0C596205; Thu, 7 Mar 2024 13:32:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0C596205 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1709814789; bh=CnKV7YkmwKVN45OVgq9HMp191oP0lkB4cDHb6peK+T4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=T2KDEMpmoxRv0tdTcMVo33+Hd8NNeNaN36V+TMSmkJZ5FJyrhMznm9lpSgdmfs3nS o2qnGiMw6uhipqyvyw8ujFusskwvKbCN2ijdmNoQyVg4YFryQVt3ckvljCjHVywbgq tplyIQ+OfbFoc7S9QhNWoR2j6sUBWdsCrEpew35Q= Received: by alsa1.perex.cz (Postfix, from userid 50401) id C9A38F80578; Thu, 7 Mar 2024 13:32:35 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 4F022F8057F; Thu, 7 Mar 2024 13:32:35 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A3D86F8024E; Thu, 7 Mar 2024 13:32:29 +0100 (CET) Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 99E6CF80087 for ; Thu, 7 Mar 2024 13:32:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 99E6CF80087 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=lBx1+QuJ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1709814736; bh=CnKV7YkmwKVN45OVgq9HMp191oP0lkB4cDHb6peK+T4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=lBx1+QuJTEVHApTpCCDU+EV1Aykxe0USdn1M5qeFxUu86nOmkjduBDq8dT3o7qXpm oS8/qBbiILsQJC5KQx/qJRP/+1Rtwj+Mvna+PmMaQHKiOOUzj3K4BfsAnCXpYBeO5i sIHi1sZKR2G1jRkcILr1PE7EJZw85kHZ0/HyQZD5Je+4MUjufb3f6fIkyubjPbz8re /xYRYrDhHsNlHZi8hwJ5D8xkg2qXwM8ii3IePd37e1Jh7QAPge7a0+jwCSZNdI+ZOe Y4f3knEgXbFr14hWz3pvmzLU64Pzxk2jZ5fbpD4Fd7BcqwRmHFTOSol/RnqeVlE3F0 mpc6I8Pch7Hkg== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Tr7wZ6z4Xz4wc8; Thu, 7 Mar 2024 23:32:14 +1100 (AEDT) From: Michael Ellerman To: Dawei Li , Christophe Leroy Cc: "npiggin@gmail.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-ide@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-serial@vger.kernel.org" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3] powerpc: macio: Make remove callback of macio driver void returned In-Reply-To: References: <3dc29701-239f-4a3b-b571-b9732975bd73@csgroup.eu> Date: Thu, 07 Mar 2024 23:32:14 +1100 Message-ID: <87bk7qnrxt.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: IM3OD323R2T5LOVS6CUXNYH4VCDJQGF5 X-Message-ID-Hash: IM3OD323R2T5LOVS6CUXNYH4VCDJQGF5 X-MailFrom: mpe@ellerman.id.au X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Dawei Li writes: > Hi Christophe, > > On Tue, Feb 20, 2024 at 04:12:17PM +0000, Christophe Leroy wrote: >> Hi Michael, >>=20 >> ping ? >>=20 >> Le 01/02/2023 =C3=A0 15:36, Dawei Li a =C3=A9crit=C2=A0: >> > Commit fc7a6209d571 ("bus: Make remove callback return void") forces >> > bus_type::remove be void-returned, it doesn't make much sense for any >> > bus based driver implementing remove callbalk to return non-void to >> > its caller. >> >=20 >> > This change is for macio bus based drivers. >> >=20 >> > Signed-off-by: Dawei Li >>=20 >> This patch is Acked , any special reason for not applying it ? >>=20 >> Note that it now conflicts with commit 1535d5962d79 ("wifi: remove=20 >> orphaned orinoco driver") but resolution is trivial, just drop the=20 >> changes to that file. > > Thanks for picking it up, hardly believe that it's been one year. > > Michael, > > I will respin V4 if it's needed. No that's fine, I'll sort it out. cheers