From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2728C0015E for ; Fri, 21 Jul 2023 14:51:36 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 92A091FE; Fri, 21 Jul 2023 16:50:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 92A091FE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1689951094; bh=/lt2nCXl8oRLecjuKOUeljZWk5t++dKudm0w8izZB+8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=QpQHLwEceBaQXh8H2oPbj+LFbFmsnaodSr5yUFRiKNOqB4rx69jMK/Fa7SsMV5Wsf fwp5Eo4dBI7KJ2QEHK4hUctbCYAV7Q2j12Ci9Nmyku9SULNcLuGHomI9vERlpkmm3w jMG7XzsAoXukF0Ll6KLocaLrU3YXeGkYP25b/wYI= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 212FBF8032D; Fri, 21 Jul 2023 16:50:44 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id A002DF8047D; Fri, 21 Jul 2023 16:50:43 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A3775F8047D; Fri, 21 Jul 2023 16:50:40 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6AF7EF8007E for ; Fri, 21 Jul 2023 16:50:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6AF7EF8007E Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ONVDuTkf; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7abz8qmX Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 431DE218A0; Fri, 21 Jul 2023 14:50:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689951036; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vCBDLdIX566wZPqhuE9j3nMUEKvAtwBa3Y1ipHMwwHM=; b=ONVDuTkf/fZMUwAz/38SG08TVMvLgLI2o9TLB9RCx0OqPdvjp/AS3PD20nsVMAT1zHHfH+ r/gfRuRVN3YGakUqctsm3ZYPhZcROLfT5y1+zMIF9E77Bo8f87FeOy7K3b0yffgO9eu4Ye AV6ydvb4Twf41cqrtoViHo6s6FpCYa4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689951036; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vCBDLdIX566wZPqhuE9j3nMUEKvAtwBa3Y1ipHMwwHM=; b=7abz8qmX5hP+OmDH2enyXnwVkG2M8DYye3Tw4grfB2kjlYSD5GpQeTEnfoMQ8TWJUpwDtk /sNi1yclVWJv5dAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0A7C8134BA; Fri, 21 Jul 2023 14:50:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4H2WATybumQ2GQAAMHmgww (envelope-from ); Fri, 21 Jul 2023 14:50:36 +0000 Date: Fri, 21 Jul 2023 16:50:35 +0200 Message-ID: <87bkg5z5c4.wl-tiwai@suse.de> From: Takashi Iwai To: Richard Fitzgerald Cc: , , , , , Subject: Re: [PATCH v5 00/11] ALSA: hda: Adding support for CS35L56 on HDA systems In-Reply-To: <20230721132120.5523-1-rf@opensource.cirrus.com> References: <20230721132120.5523-1-rf@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: OHKZOCRXJM7AAJ7XI43SWAD5NR3NYFPD X-Message-ID-Hash: OHKZOCRXJM7AAJ7XI43SWAD5NR3NYFPD X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 21 Jul 2023 15:21:09 +0200, Richard Fitzgerald wrote: > > This set of patches adds support for using the CS35L56 boosted smart > amplifier on HDA systems. In these systems the CS35L56 audio is > routed through a HDA-to-I2S bridge codec. > > This doesn't include the changes to the Realtek driver to actually hook > up the CS35L56 driver, because we don't yet have the QUIRK IDs to > associate it with. But we want to publish the driver now so that it is > available for bringing up hardware with the CS35L56. > > The first 9 patches are moving code out of the ASoC driver and into the > shared library so that it can be shared with the HDA driver. > > Patch #10 fixes missing #includes in the HDA headers so that the CS35L56 > driver doesn't have to #include headers that it doesn't use. > > CHANGES SINCE V5 > The series has been rebased onto commit df4167d658d4 > ("ASoC: cs35l56: Patch soft registers to defaults"), which removes > cs35l56_reread_firmware_registers() and adds cs35l56_set_patch(). > > Changes are trivial so I have carried forward Mark's and Takashi's acks. Mark, I suppose it's fine to take all of those to my sound.git tree? Takashi