Re: [PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga 7 2-in-1 16AKP10 (17aa:391d)

Re: [PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga 7 2-in-1 16AKP10 (17aa:391d)

[Takashi Iwai]

On Tue, 24 Mar 2026 23:24:45 +0100,
Odin Brodersen wrote:
> 
> Hi Takashi,
> 
> I'm submitting this patch directly as my alsa-devel submission is awaiting
> moderator approval (first post from a Yahoo address).

You don't need to submit to alsa-devel ML but only to linux-sound ML
for kernel patches.  Bu

> The Lenovo Yoga 7 2-in-1 16AKP10 (subsystem ID 17aa:391d) shares the
> same ALC287 codec and bass speaker pin layout as the Yoga 7 2-in-1
> 14AKP10 (17aa:391c), which already has a quirk entry. Without this
> fixup the kernel picks up the PCI SSID 17aa:38b5 (PCIe bridge) instead
> of the codec SSID, leaving the bass speaker pin (Node 0x17) inactive
> and the master volume uncontrollable.
> 
> Apply the existing ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN fixup to
> 17aa:391d to match the behaviour of the 14-inch sibling.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=221210
> Tested-by: Odin Brodersen <Odin_B@yahoo.com>
> 
> Signed-off-by: Odin Brodersen <Odin_B@yahoo.com>
> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7576,6 +7576,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
> 	SND_PCI_QUIRK(0x17aa, 0x38b4, "Legion Slim 7 16IRH8", ALC287_FIXUP_CS35L41_I2C_2),
> 	HDA_CODEC_QUIRK(0x17aa, 0x391c, "Lenovo Yoga 7 2-in-1 14AKP10", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
> +	HDA_CODEC_QUIRK(0x17aa, 0x391d, "Lenovo Yoga 7 2-in-1 16AKP10", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
> 	SND_PCI_QUIRK(0x17aa, 0x38b5, "Legion Slim 7 16IRH8", ALC287_FIXUP_CS35L41_I2C_2),
> 	SND_PCI_QUIRK(0x17aa, 0x38b6, "Legion Slim 7 16APH8", ALC287_FIXUP_CS35L41_I2C_2),
> 	SND_PCI_QUIRK(0x17aa, 0x38b7, "Legion Slim 7 16APH8", ALC287_FIXUP_CS35L41_I2C_2),
> --
> 2.43.0

Hmm, have you created a patch properly by git-format-patch or such?
It looks malformed and doesn't apply cleanly.  Try to apply this post
on your side via git-am.

At best, test posting patches locally at first, and once after you
confirmed that everything works, try to resubmit.


thanks,

Takashi

Re: [PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga 7 2-in-1 16AKP10 (17aa:391d)

[Takashi Iwai]

On Sun, 22 Mar 2026 18:37:52 +0100,
Odin Brodersen wrote:
> 
> The Lenovo Yoga 7 2-in-1 16AKP10 (subsystem ID 17aa:391d) shares the
> same ALC287 codec and bass speaker pin layout as the Yoga 7 2-in-1
> 14AKP10 (17aa:391c), which already has a quirk entry. Without this
> fixup the kernel picks up the PCI SSID 17aa:38b5 (PCIe bridge) instead
> of the codec SSID, leaving the bass speaker pin (Node 0x17) inactive
> and the master volume uncontrollable.
> 
> Apply the existing ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN fixup to
> 17aa:391d to match the behaviour of the 14-inch sibling.
> 
> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=221210
> Tested-by: Odin Brodersen <Odin_B@yahoo.com>
> 
> Signed-off-by: Odin Brodersen <Odin_B@yahoo.com>

Unfortunately the patch doesn't seem to have reached to the public ML
(neither linux-sound ML nor alsa-devel ML) by some reason, and more
importantly, the code change appears to be based on the old kernel
tree.  Please try to rebase to the latest Linux tree and resubmit
properly.


thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7576,6 +7576,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x17aa, 0x38b4, "Legion Slim 7 16IRH8", ALC287_FIXUP_CS35L41_I2C_2),
>  	HDA_CODEC_QUIRK(0x17aa, 0x391c, "Lenovo Yoga 7 2-in-1 14AKP10", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
> +	HDA_CODEC_QUIRK(0x17aa, 0x391d, "Lenovo Yoga 7 2-in-1 16AKP10", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
>  	SND_PCI_QUIRK(0x17aa, 0x38b5, "Legion Slim 7 16IRH8", ALC287_FIXUP_CS35L41_I2C_2),
>  	SND_PCI_QUIRK(0x17aa, 0x38b6, "Legion Slim 7 16APH8", ALC287_FIXUP_CS35L41_I2C_2),
>  	SND_PCI_QUIRK(0x17aa, 0x38b7, "Legion Slim 7 16APH8", ALC287_FIXUP_CS35L41_I2C_2),
> --
> 2.43.0
>