From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 999D3C38A2D for ; Tue, 25 Oct 2022 06:22:13 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C12FD5987; Tue, 25 Oct 2022 08:21:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C12FD5987 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1666678930; bh=YiKWvah4iOrmizoqowGJlpBdjdvxofKgww6F5Vr71AQ=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=afG40ovE1m8AN4SRudo3WPufqyAR1HztQ0B16SMUHIU33VkYV2rJVPDwMWX5VLb9/ zI4wDZjLa44bAFIF5HA/OBU0gLlD9MSpS6R9Ud8UT8LnXUg5Xkv0rNzCHcqnYuJoS1 qjPweYWppGbAMvFVs8EhnygtpEUVhh6B7oCI01rs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4CD54F8042F; Tue, 25 Oct 2022 08:21:20 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7E4EEF80431; Tue, 25 Oct 2022 08:21:19 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1FB88F80100 for ; Tue, 25 Oct 2022 08:21:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1FB88F80100 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="nlVRVJUy"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="+mNlM+Wv" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 990EB22092; Tue, 25 Oct 2022 06:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1666678871; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0KODU7N4U0VmRJ1kzbKr5/bp6nSUrehDMXfrT6cssK8=; b=nlVRVJUybDiViDUpxvLDvKrM+wVDnDZ1bL5dNdrqI2rjRyhTn91HZSflJ7kHehM8aAqMlY JAltsfcxvbIKISy7qVKe9wJkif0nHdTzM7GEYz2AVP9l1AivjQz0sJaj2p+UoFWuxbg+Mt +iK8lsnrMcZc8chIZHQM5SX84VOpXRI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1666678871; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0KODU7N4U0VmRJ1kzbKr5/bp6nSUrehDMXfrT6cssK8=; b=+mNlM+WvE1nlJpiBvxfj7PTka3/d3TVNBEZ6l89SvhFt1EbchlPPoL+tAdCZB4lgSHfhhi 6u6+VENWzrOQgIAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 70FF3134CA; Tue, 25 Oct 2022 06:21:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id p1HDGleAV2OjXgAAMHmgww (envelope-from ); Tue, 25 Oct 2022 06:21:11 +0000 Date: Tue, 25 Oct 2022 08:21:10 +0200 Message-ID: <87czags9t5.wl-tiwai@suse.de> From: Takashi Iwai To: "Jason A. Donenfeld" Subject: Re: [PATCH] ALSA: au88x0: use explicitly signed char In-Reply-To: References: <20221024162929.536004-1-Jason@zx2c4.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: Takashi Iwai , Al Viro , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 25 Oct 2022 01:59:50 +0200, Jason A. Donenfeld wrote: > > Hi Al, > > On Mon, Oct 24, 2022 at 11:11 PM Al Viro wrote: > > > > On Mon, Oct 24, 2022 at 06:29:29PM +0200, Jason A. Donenfeld wrote: > > > With char becoming unsigned by default, and with `char` alone being > > > ambiguous and based on architecture, signed chars need to be marked > > > explicitly as such. This fixes warnings like: > > > > It might make sparse to STFU, but it does *not* resolve the underlying > > issue: > > > > vortex_adb_checkinout() returns a number in range of 0..31 on success > > and -ENOMEM on failure. Quite a few callers don't bother to check... > > Yea, I saw that. I assume that the places that don't check don't > *need* to check. But maybe this driver is junk and other bugs lurk. > I'm not sure. Either way, I think this change is certainly an > improvement on the status quo. I don't intend to develop further on > it, but feel free to send patches atop once this lands. Yes, the driver is likely broken in some other way, too. Such a corner case doesn't hit usually, and it's unlikely worth to spend too much time on it. In anyway, I applied the patch now to for-next branch. Thanks! Takashi