From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A1FCECAAD3 for ; Wed, 14 Sep 2022 09:23:00 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 140201866; Wed, 14 Sep 2022 11:22:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 140201866 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1663147378; bh=WQCzoJ6uMZBm4bY/d9RRu7R+LnkmFVCENCQ46AmNq5I=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=q2nRqmJ1TsVagKlRzTm0qf/vS3RrxKA7RwyOahrcrweGPpGYlfgFfVGtFkuzObZi5 rXS8U0uj1s/mvW8kXrFtMfxbPc5SYA6J/mlvGF7IiWjL0u+sKb9dfT8vZN/QYSGnHx d7QZnq88VXMruF90QSV3qUhLh0z4gpCaVD5dytoI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 94E9AF8014B; Wed, 14 Sep 2022 11:22:07 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 66E79F8014E; Wed, 14 Sep 2022 11:22:06 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 140C2F800FE for ; Wed, 14 Sep 2022 11:22:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 140C2F800FE Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="conctAuZ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="ACsEW3uh" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CF4995CD3D; Wed, 14 Sep 2022 09:22:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1663147322; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YR/csYQvhJ+8IMgLXnrUwslZgXXYnqIcyBjJNajDkik=; b=conctAuZ/tqHfO+mcsRooZPpxeKQEv4VmtdjKL9oUJdbZInGiRVW+dfd90xxH5mvDXc5KZ QoHoa/8LHmdJFUN1hUjH+BVy1IiIG23/FboEq/mTsZUHka9EjaN0sAgbNMsVC0zJ7tCCYG VAL8Ccj2vgw46f4IdXkYVoUXg7nRMhs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1663147322; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YR/csYQvhJ+8IMgLXnrUwslZgXXYnqIcyBjJNajDkik=; b=ACsEW3uhUN7RZRLLr0DyP6QF9of7UCDzsWs4sgrZ26Moo0IghNXyPZJH6JGRNi+yNaSYJZ pnXTndPq/f/lgfCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B835B13494; Wed, 14 Sep 2022 09:22:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MANNLDqdIWOwJwAAMHmgww (envelope-from ); Wed, 14 Sep 2022 09:22:02 +0000 Date: Wed, 14 Sep 2022 11:22:02 +0200 Message-ID: <87czbye2f9.wl-tiwai@suse.de> From: Takashi Iwai To: acheronfail Subject: Re: [PATCH v2] ALSA: hda/realtek: Enable 4-speaker output Dell Precision 5570 laptop In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 14 Sep 2022 11:14:00 +0200, acheronfail wrote: > > The Dell Precision 5570 uses the same 4-speakers-on-ALC289 just like the > previous Precision 5560. I replicated that patch onto this one, and can > confirm that the audio is much better (the woofers are now working); > I've tested it on my Dell Precision 5570. > > Signed-off-by: Callum Osmotherly > > --- > Thanks to Takashi for helping me out with the right formatting! Glad to hear. One more thing I forgot to mention, though: if you keep the name in From field different from Signed-off-by line, you can embed the From tag into the patch itself, too, so that it's applied consistently. That is, a patch text will be: From: Callum Osmotherly The Dell Precision 5570 uses the same 4-speakers-on-ALC289 just like the previous Precision 5560. I replicated that patch onto this one, and can confirm that the audio is much better (the woofers are now working); I've tested it on my Dell Precision 5570. Signed-off-by: Callum Osmotherly I already applied this patch with the correction in my side now, so it's just a hint for the next submission :) thanks, Takashi