From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB8E5C77B7C for ; Thu, 11 May 2023 16:07:40 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5023EF0D; Thu, 11 May 2023 18:06:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5023EF0D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683821258; bh=HR/MmjA8ADp4MHdDb7JNcg7dDl4DOulN9Ab6Z4XVqt8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=M8Wm6vTJO7oFqMIU9FZtbmKamEt2GILwlbImcK4j6BhhI3gCxlUlDQmmj8PdV1O/R mpP9QDt8x29avBh8/XbKSzGDzCXrCWcaaEFr6KNyyOQpeGgI0a7PyqgS7DVYleEFSe UGFuNFo3re8y6Z69xq0mwfT+oMU4fB0O7as/pAMA= Received: by alsa1.perex.cz (Postfix, from userid 50401) id C8D9EF80551; Thu, 11 May 2023 18:06:21 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 50480F8014C; Thu, 11 May 2023 18:06:21 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E4FE7F8052E; Thu, 11 May 2023 18:06:17 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3CA0BF8014C for ; Thu, 11 May 2023 18:06:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3CA0BF8014C Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tz+kh13Q; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=xxGYa1rd Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 10DDC1FF6A; Thu, 11 May 2023 16:06:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683821175; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YJckLey2rE6VlDnueYStqSpphJd9RqYm1BabcoHNEPc=; b=tz+kh13QsgrUgtRdwIXVmBM2aZDqM1so8lhj6k/FKawaBu6NzApPenr6iOgUBGjEHfJbLX q9dN7dMII0mlA9mEbgaQBBJ6AoyQEjBD4+Xa1Yg29dSmMNmGVkQvALK7x6kvvGGNV1p9t6 X36jMQmEH07j/tl+KiqNIDkltR5bLjw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683821175; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YJckLey2rE6VlDnueYStqSpphJd9RqYm1BabcoHNEPc=; b=xxGYa1rdGqsnllvCimWrm9cOb28bsSBtdGBmbhdkcZWyqsaoOwtO7i1kjYpV0KRO/I0LfV SQITYvX00jKC1pCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BB58A134B2; Thu, 11 May 2023 16:06:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JvSHLHYSXWRIBAAAMHmgww (envelope-from ); Thu, 11 May 2023 16:06:14 +0000 Date: Thu, 11 May 2023 18:06:14 +0200 Message-ID: <87ednm4zux.wl-tiwai@suse.de> From: Takashi Iwai To: nemesis@icequake.net Cc: alsa-devel@alsa-project.org, Jaroslav Kysela , Stefan Binding , Meng Tang , Andy Chi , "Luke D. Jones" , Philipp Jungkamp , Kacper =?ISO-8859-2?Q?Michaj=B3ow?= , Yuchi Yang , linux-kernel@vger.kernel.org Subject: Re: [PATCH] snd-hda-intel: Apply HP B&O top speaker profile to Pavilion 15 In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: S73BRZMHXUF4YWYP5UIABOU5XTF75XPR X-Message-ID-Hash: S73BRZMHXUF4YWYP5UIABOU5XTF75XPR X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 10 May 2023 18:19:08 +0200, Ryan C. Underwood wrote: > > > The Pavilion 15 line has B&O top speakers similar to the x360 and > applying the same profile produces good sound. Without this, the sound > would be tinny and underpowered without either applying > model=alc295-hp-x360 or booting another OS first. The code change looks OK, but could you give your Signed-off-by tag? It's a legal requirement and mandatory for merging to the upstream. Also, you can reduce the recipients in Cc a bit more. For this kind of trivial change, just maintainers and ML should suffice. thanks, Takashi