From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <error27@gmail.com>
Cc: alsa-devel@alsa-project.org, Clemens Ladisch <clemens@ladisch.de>,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ALSA: fireface: fix locking bug in ff400_copy_msg_to_user()
Date: Wed, 18 Jan 2023 17:50:05 +0100 [thread overview]
Message-ID: <87edrr6b42.wl-tiwai@suse.de> (raw)
In-Reply-To: <Y8at+W/7OGvEBY8O@kili>
On Tue, 17 Jan 2023 15:17:29 +0100,
Dan Carpenter wrote:
>
> The ff400_copy_msg_to_user() function drops the spin lock to call
> copy_to_user(). However, if the copy_to_user() fails, then it must
> take the lock again before returning. Failure to take the lock leads
> to a double unlock in the caller, hwdep_read().
>
> Fixes: acdebd8b4c0c ("ALSA: fireface: implement message parser for Fireface 400")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Thanks, applied.
Takashi
prev parent reply other threads:[~2023-01-18 16:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 14:17 [PATCH] ALSA: fireface: fix locking bug in ff400_copy_msg_to_user() Dan Carpenter
2023-01-18 0:08 ` Takashi Sakamoto
2023-01-18 16:50 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edrr6b42.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox