From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5069EC43334 for ; Mon, 13 Jun 2022 05:42:18 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9245116CB; Mon, 13 Jun 2022 07:41:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9245116CB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1655098936; bh=2Lfh4pda6TY+K1C96k7ocNNFcO104P+MzAEG1R0c0XM=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DdQDExmC6ylV7I1gFwCzmbCB4npgcH+l4KStxzfN3dRfwdPw2tIPgtFTk8rp58TDr SbxCC+BTxL6cqxy7xg1h5mE649vYHqiuIK8Lw39ywRrJWeJDljIsQ9pPWasBBwBZxh JDgKmInJbpQr09Wyraxm0IF/Y8UOZYCNv55yiU1U= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 15D0BF804BB; Mon, 13 Jun 2022 07:41:26 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 467E1F804C1; Mon, 13 Jun 2022 07:41:24 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 90951F800D8 for ; Mon, 13 Jun 2022 07:41:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 90951F800D8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="sEUK/XO2"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="BVoNivKB" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E19551F91B; Mon, 13 Jun 2022 05:41:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1655098872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3dINdTPcWskYcY4vaHavZqUpGKTEZb/iEHgT5+r3rkI=; b=sEUK/XO2825jyPzqfgauovi913iP9V+rVVL1jeonqZUh91YxzlEYTnvaNHJtAio13YBdPo v/oPSVzDCPpZ8kP8EVevZuSY6pRt7G50Z1h9W8KJyDZ9t4u+dICM1HcX2b4QtTTqarla4y aVuptZqZpvR/GfdWlY5slmMieU8Cihg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1655098872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3dINdTPcWskYcY4vaHavZqUpGKTEZb/iEHgT5+r3rkI=; b=BVoNivKBgpz8BtiMTCIHUiwn5BoVYysZMR6nylaDkjCiLtcmPu3dzuGkGq/7oot3uFd/CK 8lnEtn3nQbAz0HAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B24F113941; Mon, 13 Jun 2022 05:41:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qyWdKfjNpmJ3bQAAMHmgww (envelope-from ); Mon, 13 Jun 2022 05:41:12 +0000 Date: Mon, 13 Jun 2022 07:41:12 +0200 Message-ID: <87edztt91j.wl-tiwai@suse.de> From: Takashi Iwai To: Daniil Dementev Subject: Re: [PATCH] ALSA: usb-audio: US16x08: Move overflow check before array access In-Reply-To: <20220610165732.2904-1-d.dementev@ispras.ru> References: <20220610165732.2904-1-d.dementev@ispras.ru> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , Alexey Khoroshilov X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 10 Jun 2022 18:57:32 +0200, Daniil Dementev wrote: > > Buffer overflow could occur in the loop "while", due to accessing an > array element before checking the index. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Daniil Dementev > Reviewed-by: Alexey Khoroshilov Thanks, applied. Takashi