From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: kbuild test robot <lkp@intel.com>
Cc: Simon <horms@verge.net.au>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>,
kbuild-all@01.org, Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] ASoC: soc-core: fix ifnullfree.cocci warnings
Date: Thu, 14 Sep 2017 01:17:41 +0000 [thread overview]
Message-ID: <87efrajdad.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20170914010801.GA116841@lkp-g5.lkp.intel.com>
Hi
> sound/soc/soc-core.c:643:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
>
> NULL check before some freeing functions is not needed.
>
> Based on checkpatch warning
> "kfree(NULL) is safe this check is probably not required"
> and kfreeaddr.cocci by Julia Lawall.
>
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
>
> Fixes: 7e74acb4fc31 ("ASoC: soc-core: remove rtd NULL check from soc_free_pcm_runtime()")
> CC: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
next prev parent reply other threads:[~2017-09-14 1:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 7:44 [bug report] ASoC: soc-core: add snd_soc_rtdcom_xxx() Dan Carpenter
2017-09-11 8:22 ` Kuninori Morimoto
2017-09-11 8:32 ` [PATCH] ASoC: soc-core: remove rtd NULL check from soc_free_pcm_runtime() Kuninori Morimoto
2017-09-14 1:08 ` [PATCH] ASoC: soc-core: fix ifnullfree.cocci warnings kbuild test robot
2017-09-14 1:17 ` Kuninori Morimoto [this message]
2017-09-14 1:08 ` [PATCH] ASoC: soc-core: remove rtd NULL check from soc_free_pcm_runtime() kbuild test robot
-- strict thread matches above, loose matches on Subject: below --
2019-05-30 23:06 [PATCH] ASoC: soc-core: fix ifnullfree.cocci warnings Julia Lawall
2019-06-03 17:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efrajdad.wl%kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=horms@verge.net.au \
--cc=kbuild-all@01.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).