* [PATCH v1] ALSA: hda/tas2781: Ignore irq for I2C device
@ 2025-11-22 9:59 Baojun Xu
2025-11-24 7:36 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Baojun Xu @ 2025-11-22 9:59 UTC (permalink / raw)
To: tiwai
Cc: broonie, andriy.shevchenko, alsa-devel, shenghao-ding,
13916275206, linux-sound, linux-kernel, baojun.xu
In some projects (HP Lampass), no GPIO was assigned for irq,
it would be better to ignore it.
Signed-off-by: Baojun Xu <baojun.xu@ti.com>
---
drivers/platform/x86/serial-multi-instantiate.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/platform/x86/serial-multi-instantiate.c b/drivers/platform/x86/serial-multi-instantiate.c
index db030b0f176a..86cecf3ed916 100644
--- a/drivers/platform/x86/serial-multi-instantiate.c
+++ b/drivers/platform/x86/serial-multi-instantiate.c
@@ -214,8 +214,6 @@ static int smi_i2c_probe(struct platform_device *pdev, struct smi *smi,
board_info.dev_name = name;
ret = smi_get_irq(pdev, adev, &inst_array[i]);
- if (ret < 0)
- goto error;
board_info.irq = ret;
smi->i2c_devs[i] = i2c_acpi_new_device(dev, i, &board_info);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] ALSA: hda/tas2781: Ignore irq for I2C device
2025-11-22 9:59 [PATCH v1] ALSA: hda/tas2781: Ignore irq for I2C device Baojun Xu
@ 2025-11-24 7:36 ` Andy Shevchenko
2025-11-24 8:33 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2025-11-24 7:36 UTC (permalink / raw)
To: Baojun Xu
Cc: tiwai, broonie, alsa-devel, shenghao-ding, 13916275206,
linux-sound, linux-kernel
On Sat, Nov 22, 2025 at 05:59:03PM +0800, Baojun Xu wrote:
> In some projects (HP Lampass), no GPIO was assigned for irq,
> it would be better to ignore it.
I don't think this is correct approach, but Hans probably knows better
the code.
Also when touching this kind of drivers, please provide ACPI DSDT excerpt
to show the Device object description in question.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] ALSA: hda/tas2781: Ignore irq for I2C device
2025-11-24 7:36 ` Andy Shevchenko
@ 2025-11-24 8:33 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2025-11-24 8:33 UTC (permalink / raw)
To: Baojun Xu
Cc: Andy Shevchenko, broonie, alsa-devel, shenghao-ding, 13916275206,
linux-sound, linux-kernel
On Mon, 24 Nov 2025 08:36:49 +0100,
Andy Shevchenko wrote:
>
> On Sat, Nov 22, 2025 at 05:59:03PM +0800, Baojun Xu wrote:
> > In some projects (HP Lampass), no GPIO was assigned for irq,
> > it would be better to ignore it.
>
> I don't think this is correct approach, but Hans probably knows better
> the code.
>
> Also when touching this kind of drivers, please provide ACPI DSDT excerpt
> to show the Device object description in question.
Yes, and the patch was submitted rather to the wrong target.
It's no sound driver but x86 platform driver.
Please resubmit to the right target.
thanks,
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-26 14:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-22 9:59 [PATCH v1] ALSA: hda/tas2781: Ignore irq for I2C device Baojun Xu
2025-11-24 7:36 ` Andy Shevchenko
2025-11-24 8:33 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).