From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21880C7618E for ; Fri, 21 Apr 2023 15:34:12 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 562ECE94; Fri, 21 Apr 2023 17:33:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 562ECE94 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1682091250; bh=xR7GU6dYfwfqtr8dqEMpfylmsQRDJOGiKX09k9DVQP8=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=eWo4k924tcDF5YXHVHblzi92CUjssy3l0C23TYWpaKTN9WrvYZfVGoSy9OTD9Narb JTq8RrMyFJhC/I9oSOa2y1884FifHdk7HO0jeQ1pHOQqOiiYTYx04TgqDlqq+xg96g /MQxtqaKAz93d8NTBnM4SzsBjC3x54J/eu6Ypfk0= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id C48ECF80155; Fri, 21 Apr 2023 17:32:54 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DC6E9F80155; Fri, 21 Apr 2023 17:32:49 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F0730F800F8 for ; Fri, 21 Apr 2023 17:32:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F0730F800F8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=JkaaqwUG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YEAkyeaw Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5CDF62190B; Fri, 21 Apr 2023 15:32:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682091165; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ItdnvNb3y8eXZxISso4+julmyScR9rNxbxwXQTtBTgE=; b=JkaaqwUGWjeqILwGkiGQf1BQne44BPWeY6FF0TDx+WwiolpJu64ri1WvZx8DbhxKQx54Jd e+pj+A0H1/u/p+aDgjpAwojHsJRYx0NlO18WvezA5bhVYhLxFRMjwoq2OuZ2sFuZuf9re+ 2fqN+eyWzRFM53IacVoHa+JzcpGT0qo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682091165; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ItdnvNb3y8eXZxISso4+julmyScR9rNxbxwXQTtBTgE=; b=YEAkyeawqOCHCxx6lbqljnZfl60hN2kd2QKq0cWLdWx/cy30R3RgUG+0g1DzTrl+JEa4z+ HklwYL9OXUFlUwCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3D6531390E; Fri, 21 Apr 2023 15:32:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JA4jDp2sQmT8HwAAMHmgww (envelope-from ); Fri, 21 Apr 2023 15:32:45 +0000 Date: Fri, 21 Apr 2023 17:32:44 +0200 Message-ID: <87fs8tqmhv.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH 3/7] ALSA: emu10k1: fix snd_emu1010_fpga_read() input masking for rev2 cards In-Reply-To: References: <20230421141006.1005539-1-oswald.buddenhagen@gmx.de> <20230421141006.1005539-3-oswald.buddenhagen@gmx.de> <87leilqnct.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: RK4PINN7OVLNNKAAHUUZE2WBEA6KTM3Y X-Message-ID-Hash: RK4PINN7OVLNNKAAHUUZE2WBEA6KTM3Y X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 21 Apr 2023 17:25:46 +0200, Oswald Buddenhagen wrote: > > On Fri, Apr 21, 2023 at 05:14:10PM +0200, Takashi Iwai wrote: > > On Fri, 21 Apr 2023 16:10:02 +0200, > > Oswald Buddenhagen wrote: > >> > >> Signed-off-by: Oswald Buddenhagen > > > > No changelog is no good news. > > Please give more information. > > > i suppose this is a difference in philosophy. i generally refrain from > covering in the commit message what comments in the patch already > explain. otherwise it would be just redundant, and i don't like that > very much. > > anyway, i can add some speculation what problems this could have > theoretically caused. You didn't explain exactly *WHAT* you fixed, and that's the readers may be interested more. The summary says merely "fix snd_emu1010_fpga_read() input masking for rev2 cards". What was broken beforehand and what was corrected by your patch? The summary isn't enough for explaining it, but you have more space here. thanks, Takashi