Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: chihhao chen <chihhao.chen@mediatek.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: missing sound on kernel-5.15
Date: Tue, 30 Aug 2022 08:02:30 +0200	[thread overview]
Message-ID: <87fshe8e15.wl-tiwai@suse.de> (raw)
In-Reply-To: <87ilma8edo.wl-tiwai@suse.de>

On Tue, 30 Aug 2022 07:54:59 +0200,
Takashi Iwai wrote:
> 
> On Mon, 29 Aug 2022 20:15:33 +0200,
> Takashi Iwai wrote:
> > 
> > On Mon, 29 Aug 2022 14:16:27 +0200,
> > Takashi Iwai wrote:
> > > 
> > > On Mon, 29 Aug 2022 10:50:58 +0200,
> > > chihhao chen wrote:
> > > > 
> > > > Hi Takashi,
> > > > 
> > > > Yes.
> > > > 
> > > > To issue SAMPLING_FREQ_CONTROL USB request two times is root cause of
> > > > this issue.
> > > 
> > > Hm, is it a UAC1 device?  Such a device should work with multiple
> > > SAMPLING_FREQ_CONTROL invocations, but some device might be not
> > > tolerant or buggy...  The multiple init_sample_rate() invocations may
> > > happen with the older kernel under certain situations, so maybe we
> > > need a different fix.
> > > 
> > > How about the patch like below?
> > 
> > It's missing the clearance for suspend/resume.
> > The revised patch is below.
> 
> ... and after reading the mail again, I noticed that it's all
> rubbish, scratch the previous ones.
> 
> Have you tested it with the later kernel?  I guess this has been
> already addressed.  In the recent kernel, the rate is set per assigned
> clock, hence it won't be set up twice unnecessarily.

That said, try to cherry-pick the upstream commit
c11117b634f4f832c4420d3cf41c44227f140ce1.

If this is confirmed to work, we can ask Greg to merge it into 5.15.y
stable tree.


Takashi

  reply	other threads:[~2022-08-30  6:03 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22  8:06 missing sound on kernel-5.15 chihhao chen
2022-08-22 11:57 ` Geraldo Nascimento
2022-08-29  7:56   ` chihhao chen
2022-08-29  8:06     ` Takashi Iwai
2022-08-29  8:50       ` chihhao chen
2022-08-29 12:16         ` Takashi Iwai
2022-08-29 18:15           ` Takashi Iwai
2022-08-30  5:54             ` Takashi Iwai
2022-08-30  6:02               ` Takashi Iwai [this message]
2022-08-30  6:13               ` chihhao chen
2022-08-30  7:02                 ` Takashi Iwai
2022-08-30  8:08                   ` chihhao chen
2022-08-30  8:24                     ` Takashi Iwai
2022-08-31  3:39                       ` chihhao chen
2022-08-31  5:18                         ` Takashi Iwai
2022-08-31  7:03                           ` chihhao chen
2022-08-31  8:04                             ` Takashi Iwai
2022-08-31  9:26                               ` chihhao chen
2022-08-31 10:48                                 ` Takashi Iwai
2022-08-31 13:16                                   ` chihhao chen
2022-08-31 13:40                                     ` Takashi Iwai
2022-09-01  5:50                                       ` chihhao chen
2022-09-01  7:51                                         ` Takashi Iwai
2022-09-01  8:28                                           ` Takashi Iwai
2022-09-01 10:06                                             ` chihhao chen
2022-09-01 10:25                                               ` Takashi Iwai
2022-11-11  7:58                                                 ` Chihhao Chen (陳志豪)
     [not found] <1661150747490509987-webhooks-bot@alsa-project.org>
2022-08-22  6:45 ` GitHub issues - opened

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fshe8e15.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=chihhao.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox