From: Takashi Iwai <tiwai@suse.de>
To: Ruoyu Wang <ruoyuw560@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] ALSA: check snd_ctl_new1() return before dereferencing
Date: Sun, 07 Jun 2026 09:27:20 +0200 [thread overview]
Message-ID: <87h5nestd3.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260607025613.3604194-1-ruoyuw560@gmail.com>
On Sun, 07 Jun 2026 04:56:05 +0200,
Ruoyu Wang wrote:
>
> Several ALSA drivers dereference the pointer returned by snd_ctl_new1()
> to adjust id.device, id.index, or store bookkeeping pointers before
> calling snd_ctl_add(). snd_ctl_new1() can return NULL on allocation
> failure, making these writes a NULL pointer dereference.
>
> This series adds NULL checks to all affected call sites found by static
> analysis.
>
> Ruoyu Wang (8):
> ALSA: es18xx: check control allocation before private data setup
> ALSA: gus: check PCM volume control allocation
> ALSA: cmipci: check S/PDIF control allocations
> ALSA: es1938: check control allocation before private data setup
> ALSA: ice1712: aureon: check CS8415 control allocation
> ALSA: ice1712: check pro S/PDIF control allocations
> ALSA: ice1724: check S/PDIF control allocations
> ALSA: ymfpci: check S/PDIF control allocations
Some of them seems to have been already applied or conflicting.
Please rebase on the latest for-next branch of sound.git tree and
resubmit.
thanks,
Takashi
prev parent reply other threads:[~2026-06-07 7:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-07 2:56 [PATCH 0/8] ALSA: check snd_ctl_new1() return before dereferencing Ruoyu Wang
2026-06-07 2:56 ` [PATCH] ALSA: es18xx: check control allocation before private data setup Ruoyu Wang
2026-06-07 2:56 ` [PATCH] ALSA: gus: check PCM volume control allocation Ruoyu Wang
2026-06-07 2:56 ` [PATCH] ALSA: cmipci: check S/PDIF control allocations Ruoyu Wang
2026-06-07 2:56 ` [PATCH] ALSA: es1938: check control allocation before private data setup Ruoyu Wang
2026-06-07 2:56 ` [PATCH] ALSA: ice1712: aureon: check CS8415 control allocation Ruoyu Wang
2026-06-07 2:56 ` [PATCH] ALSA: ice1712: check pro S/PDIF control allocations Ruoyu Wang
2026-06-07 2:56 ` [PATCH] ALSA: ice1724: check " Ruoyu Wang
2026-06-07 2:56 ` [PATCH] ALSA: ymfpci: " Ruoyu Wang
2026-06-07 7:27 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5nestd3.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ruoyuw560@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox