From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7861EB64D9 for ; Tue, 4 Jul 2023 15:19:39 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7DB22210; Tue, 4 Jul 2023 17:18:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7DB22210 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1688483976; bh=g/ZTw2G13wieSmqP1vOTwnbQPbqfI6AqaxzWOfFWhnQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=dl2ljfAyThKt3K0B8d7lkO2Cc8IeK7UkZFfKFZIrrc2uxBuaCpej7nLNgzy7JWAEJ vx2H+JKVt667dduWPiUR26A/ySEFaKS5vre06UsXZymdbLNWfkcmDFvTCMKJmn+u9/ f0zsNTPDJK5uBdCjCLHWLEcnqsDeNvUarjzzUYqc= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 31E9CF80272; Tue, 4 Jul 2023 17:18:21 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 8E973F80125; Tue, 4 Jul 2023 17:18:21 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E563CF80125; Tue, 4 Jul 2023 17:18:16 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F2925F800E4 for ; Tue, 4 Jul 2023 17:18:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F2925F800E4 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Q+uIOR3r; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=l/mff3Mb Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 45C851FDBF; Tue, 4 Jul 2023 15:18:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1688483890; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=09ZFhrK9gHoXmJ/csCv5GswlFwioAkV5H04kGj7QAAo=; b=Q+uIOR3rTG4OQFhgqdczakOzPTrGAvmWL69rDYY+7k4FGWi0sGdQRc6xPrK+3Of3kKJ9UR tRPkKzbNvCuWkXd7h8mnsB8UrI2Z/pM19uSqo9ffdWd3qZEpi2A5yArQ6AG8Z4WvSIaSq4 8EraVqyOjxj6vv5E3K68WM+N87QJTKY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1688483890; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=09ZFhrK9gHoXmJ/csCv5GswlFwioAkV5H04kGj7QAAo=; b=l/mff3MbANizx6wXIOAFSZwoYCYFtctvpca4iVlEvBYfQXhTI3dIUsqjryj6QI5Md5SiEt bvhZX2DGKLSD8qBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 218B81346D; Tue, 4 Jul 2023 15:18:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +5dFBzI4pGRkGAAAMHmgww (envelope-from ); Tue, 04 Jul 2023 15:18:10 +0000 Date: Tue, 04 Jul 2023 17:18:09 +0200 Message-ID: <87h6qjpuxa.wl-tiwai@suse.de> From: Takashi Iwai To: "Pentracillin@" Cc: tiwai@suse.com, alsa-devel@alsa-project.org, "Pentracillin@" Subject: Re: [PATCH] Add Dell XPS 15 9530 ALC289 speaker fix In-Reply-To: <20230704130223.13873-1-Pentracillin@gmail.com> References: <20230704130223.13873-1-Pentracillin@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: GTNTLNLPH5SOSUXWM7DIOTWQM6PF66RZ X-Message-ID-Hash: GTNTLNLPH5SOSUXWM7DIOTWQM6PF66RZ X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 04 Jul 2023 15:02:23 +0200, Pentracillin@ wrote: > Thanks for your patch. But it needs a lot of things to be improved. A patch must have a description to explain why this change is needed and what / how the patch works. Please fill the text. And, your Signed-off-by tag is mandatory. It's a legal requirement to merge to the upstream, and it needs to be with a real name. Also, please put the new quirk entry at the right position. The table is sorted in PCI SSID order. Last but not least, please put a proper prefix to the subject line. In your case, it'd be like 'ALSA: hda/realtek: ...." thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index afe8253f9..b5b80b6cd 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -9355,6 +9355,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1028, 0x0a9d, "Dell Latitude 5430", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x1028, 0x0a9e, "Dell Latitude 5430", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x1028, 0x0b19, "Dell XPS 15 9520", ALC289_FIXUP_DUAL_SPK), > + SND_PCI_QUIRK(0x1028, 0x0beb, "Dell XPS 15 9530", ALC289_FIXUP_DUAL_SPK), > SND_PCI_QUIRK(0x1028, 0x0b1a, "Dell Precision 5570", ALC289_FIXUP_DUAL_SPK), > SND_PCI_QUIRK(0x1028, 0x0b37, "Dell Inspiron 16 Plus 7620 2-in-1", ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS), > SND_PCI_QUIRK(0x1028, 0x0b71, "Dell Inspiron 16 Plus 7620", ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS), > -- > 2.34.1 >