From: Takashi Iwai <tiwai@suse.de>
To: "Luke D. Jones" <luke@ljones.dev>
Cc: tiwai@suse.com, perex@perex.cz, sbinding@opensource.cirrus.com,
andy.chi@canonical.com, tangmeng@uniontech.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ALSA: hda/realtek: Add quirk for ASUS ROG GX650P
Date: Fri, 30 Jun 2023 10:29:01 +0200 [thread overview]
Message-ID: <87h6qpcq0i.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230630043106.914724-2-luke@ljones.dev>
On Fri, 30 Jun 2023 06:31:05 +0200,
Luke D. Jones wrote:
>
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5883,7 +5883,7 @@ static void alc_fixup_headset_mode_alc255_no_hp_mic(struct hda_codec *codec,
> struct alc_spec *spec = codec->spec;
> spec->parse_flags |= HDA_PINCFG_HEADSET_MIC;
> alc255_set_default_jack_type(codec);
> - }
> + }
> else
> alc_fixup_headset_mode(codec, fix, action);
> }
This change looks irrelevant. Could you drop it?
If it needs to be fixed, put in another cleanup patch.
thanks,
Takashi
next prev parent reply other threads:[~2023-06-30 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 4:31 [PATCH 0/2] ALSA: hda/realtek: Add quirk for ASUS ROG laptops Luke D. Jones
2023-06-30 4:31 ` [PATCH 1/2] ALSA: hda/realtek: Add quirk for ASUS ROG GX650P Luke D. Jones
2023-06-30 8:29 ` Takashi Iwai [this message]
2023-06-30 23:54 ` Luke Jones
2023-06-30 4:31 ` [PATCH 2/2] ALSA: hda/realtek: Add quirk for ASUS ROG GA402X Luke D. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6qpcq0i.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=andy.chi@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=perex@perex.cz \
--cc=sbinding@opensource.cirrus.com \
--cc=tangmeng@uniontech.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox