From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71119C7EE22 for ; Thu, 11 May 2023 16:03:43 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 45FA6F06; Thu, 11 May 2023 18:02:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 45FA6F06 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683821021; bh=CBV8odCl3RFWLtwP1mzoXMUxsoBoXZy3BrC1q2dOfcg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=jIJN/ptJDbxFwGzdN7Bq0QeHXR8yzmWGYvDWSSbeQ/py12p6GlNZI3Vb23yUkfW62 3CmD8MkV6rfO8FSNDEh0ix+5zDkZMhcBLtUi4lS8IvKpAIGcFLw/NBTcgjO8vJ5TbA s4MANhLHboY7q5o62aBNbZiJ/wFlSWgQmquxskIQ= Received: by alsa1.perex.cz (Postfix, from userid 50401) id DF360F802E8; Thu, 11 May 2023 18:02:28 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 919EDF802E8; Thu, 11 May 2023 18:02:28 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 352BCF8052E; Thu, 11 May 2023 18:02:25 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F2838F802E8 for ; Thu, 11 May 2023 18:02:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F2838F802E8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MBRp0cVn; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=zZMP78BD Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 545A21FF8C; Thu, 11 May 2023 16:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683820938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IRcN6s7OyHD80E/ijgnyaP44Gr69HdU45sBWHhRkUog=; b=MBRp0cVnD3ozAdAChK7AiN7naUzqPZRjQVwS7jhcGjow3p96g1jdMOsM4cPapCFFPKps+E 0s3GIRIoinL5CUpFmE+m9/fa9WLBrqHYJqX2hjXexydwjAjCqivNzYrjNT/ts+ECJ167+N MjctHrKsgog00VHKcBVhiqiYEqrvknk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683820938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IRcN6s7OyHD80E/ijgnyaP44Gr69HdU45sBWHhRkUog=; b=zZMP78BD7aiL/LFMM1inz7/8sTw4stQEzZ68IByatTf2wqBiR5wME1ahcCyeMifhaN1nNQ +1FoNtyl0mMos/Dw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DF3A2134B2; Thu, 11 May 2023 16:02:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5GxdNYkRXWSOAgAAMHmgww (envelope-from ); Thu, 11 May 2023 16:02:17 +0000 Date: Thu, 11 May 2023 18:02:17 +0200 Message-ID: <87h6si501i.wl-tiwai@suse.de> From: Takashi Iwai To: Alexandru Sorodoc Cc: Jaroslav Kysela , Takashi Iwai , Stefan Binding , Tim Crawford , Andy Chi , Meng Tang , "Luke D. Jones" , Philipp Jungkamp , Kacper =?ISO-8859-2?Q?Michaj=B3ow?= , Yuchi Yang , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] ALSA: hda/realtek: Add quirks for ASUS GU604V and GU603V In-Reply-To: <20230509163746.6949-1-ealex95@gmail.com> References: <20230509163746.6949-1-ealex95@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: WKB33DCSJLJHNU7J4ANCOYVY4KJ3DMJN X-Message-ID-Hash: WKB33DCSJLJHNU7J4ANCOYVY4KJ3DMJN X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 09 May 2023 18:37:46 +0200, Alexandru Sorodoc wrote: > > @@ -9543,6 +9561,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1043, 0x8398, "ASUS P1005", ALC269_FIXUP_STEREO_DMIC), > SND_PCI_QUIRK(0x1043, 0x83ce, "ASUS P1005", ALC269_FIXUP_STEREO_DMIC), > SND_PCI_QUIRK(0x1043, 0x8516, "ASUS X101CH", ALC269_FIXUP_ASUS_X101), > + SND_PCI_QUIRK(0x1043, 0x1473, "ASUS GU604V", ALC285_FIXUP_ASUS_HEADSET_MIC), > + SND_PCI_QUIRK(0x1043, 0x1483, "ASUS GU603V", ALC285_FIXUP_ASUS_HEADSET_MIC), > SND_PCI_QUIRK(0x104d, 0x9073, "Sony VAIO", ALC275_FIXUP_SONY_VAIO_GPIO2), > SND_PCI_QUIRK(0x104d, 0x907b, "Sony VAIO", ALC275_FIXUP_SONY_HWEQ), > SND_PCI_QUIRK(0x104d, 0x9084, "Sony VAIO", ALC275_FIXUP_SONY_HWEQ), The table is sorted in PCI SSID order. Could you try to put the new entries at the right point? thanks, Takashi