From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 383F2C77B7F for ; Wed, 3 May 2023 06:10:32 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A668913AE; Wed, 3 May 2023 08:09:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A668913AE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683094229; bh=W3B24W/7pztG5G5giIAlR1uik8NhUDtPk8RYZcnaWHM=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=uwJo2t8a7GXZfQYUHkbR9m16feJdx63CPvvJBHQEVUV+6cvhSql5owZDH0xObLzBY mORbFCTcTw8fNV3HduUEup+GH0CRJX7iNlC2xyWQ41bCfUKur+78VufA0OTfGnWHal 39T5aZBIr/dkFiJXXVBxyeRTGS59ukY58tpvxXdk= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 33FDDF80520; Wed, 3 May 2023 08:08:49 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EAB5CF8049E; Wed, 3 May 2023 08:08:18 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B6AD1F800EC for ; Wed, 3 May 2023 08:08:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B6AD1F800EC Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=lM412DW6; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=c2v7kafu Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0F9B7222C0; Wed, 3 May 2023 06:08:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683094094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qpbCSszVr46DriBA7/WJQ7lj+XHfHPDBGRbf2/7ktVE=; b=lM412DW6Frf8JnO9H/P1wXkkGe837O06CzHtfgyTmQNeUV8f3FFffg9OgESoimKEQvLJ1g 6f6yK80WDyeBDYB0MGsGtORA2tYKSjz3hdHJSLP3mlt8xLXQgmZ6vsi8PD5FWWHHYIF8SF YCnYF6dtLxjyIAKKY19fyZkM5Iizi40= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683094094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qpbCSszVr46DriBA7/WJQ7lj+XHfHPDBGRbf2/7ktVE=; b=c2v7kafuMkO5hc8n85vXXla6Tk3AqZAkOR9HiTRMugEVh2qaIHbTkIdwFbOaymgy6TIFXG AzGExnRA0bGlUQAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DE25113584; Wed, 3 May 2023 06:08:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mK9VNU36UWR5JgAAMHmgww (envelope-from ); Wed, 03 May 2023 06:08:13 +0000 Date: Wed, 03 May 2023 08:08:13 +0200 Message-ID: <87h6sune0i.wl-tiwai@suse.de> From: Takashi Iwai To: "Luke D. Jones" Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for 2nd ASUS GU603 In-Reply-To: <20230503035035.254346-1-luke@ljones.dev> References: <20230503035035.254346-1-luke@ljones.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: Q3KK4ZM7MGCHEEIX7Y45RETUIMCN5MJL X-Message-ID-Hash: Q3KK4ZM7MGCHEEIX7Y45RETUIMCN5MJL X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 03 May 2023 05:50:35 +0200, Luke D. Jones wrote: > > Add quirk for GU603 with 0x1c62 variant of codec. > > Signed-off-by: Luke D. Jones > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 3b9f077a227f..4a585050edc3 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -9501,6 +9501,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), > SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK), > SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401), > + SND_PCI_QUIRK(0x1043, 0x1c62, "ASUS GU603", ALC289_FIXUP_ASUS_GA401), > SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC), > SND_PCI_QUIRK(0x1043, 0x1740, "ASUS UX430UA", ALC295_FIXUP_ASUS_DACS), > SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", ALC294_FIXUP_ASUS_DUAL_SPK), Could you try to put the new entry at the right place? The table is sorted in the PCI SSID order. thanks, Takashi