From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9574C6FD18 for ; Sat, 22 Apr 2023 15:34:34 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A9FE7EDE; Sat, 22 Apr 2023 17:33:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A9FE7EDE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1682177672; bh=3duk4fXYSFrVLCHDr3xxXE5CABcMBXwt3Tuzc7cH47Y=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=OtL3IR4Va2oClFVDpp6wObn/B4Jf/quLbLxVUQxydiITI/uRjOc1QdVkn8ChFsRlT utjAn+Mn4KUhtKJVBD9Sy7rMaTCOGN0sU+ez9+byW4aiupxygwI0Xx3YUlNGx7nZ8l hSVpyPXQjJXYkE0aaUruME5ahKpvsz8NbilcRG5Y= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 982BDF80155; Sat, 22 Apr 2023 17:33:17 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A18BDF80155; Sat, 22 Apr 2023 17:33:10 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 51146F800D0 for ; Sat, 22 Apr 2023 17:33:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 51146F800D0 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gEnkSMwg; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=8bEKM6ah Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CA5521FDF0; Sat, 22 Apr 2023 15:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682177587; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5y3I+2kk2vrszd/Xe9SRu5Ksjym2j7v43pFnFmiYt28=; b=gEnkSMwglW//lxiUm03JTBC0wNLGJyyJbbsT4X8JBrKaldmhzCTxkOilPkWXBTgpufcbn+ dN3v4OGlaKeBs8KkXO/G0iqEYRpQ73UT8CafgqjmWKwYfj0QYLtnHN2SCG7LebA1TI2Bse vvfAPqIaDBOSGTUoU1AkGbL6qU2yhPY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682177587; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5y3I+2kk2vrszd/Xe9SRu5Ksjym2j7v43pFnFmiYt28=; b=8bEKM6ahEZ71RZfLqLW1UyjXCQGxEPgi6VRhHiszG6pzBDMBUT+MGVgS4qlcdNAc7I4c/E A8+9Wiy8H+J/rbDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 87D1C13499; Sat, 22 Apr 2023 15:33:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DK0yIDP+Q2QqUQAAMHmgww (envelope-from ); Sat, 22 Apr 2023 15:33:07 +0000 Date: Sat, 22 Apr 2023 17:33:06 +0200 Message-ID: <87h6t8ort9.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH v2] ALSA: emu10k1: minor optimizations In-Reply-To: <20230422121519.1052813-1-oswald.buddenhagen@gmx.de> References: <20230422121519.1052813-1-oswald.buddenhagen@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: 6JLO7JUV4LZYF3OAGP7YCOJ3Y7KYTGCC X-Message-ID-Hash: 6JLO7JUV4LZYF3OAGP7YCOJ3Y7KYTGCC X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sat, 22 Apr 2023 14:15:19 +0200, Oswald Buddenhagen wrote: > > - In snd_emu10k1_look_for_ctl(), evaluate the cheap condition first > - In _snd_emu10k1_{audigy_,}init_efx(), don't use expensive bit setting > loops to fill arrays > - In snd_emu_proc_ptr_reg_read(), remove useless condition - iobase can > be only 0 or 0x20 > > Signed-off-by: Oswald Buddenhagen > --- > v2: > - fix fill sizes for sblive by using the previous hard-coded numbers. > it might be a good idea to introduce constants for that, but that's > for another patch. Thanks, applied now. Takashi