Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Matthias Reichl <hias@horus.com>, Mark Brown <broonie@kernel.org>,
	Stefan Wahren <stefan.wahren@i2se.com>
Cc: alsa-devel@alsa-project.org, linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] ASoC: bcm2835: Support additional samplerates up to 384kHz
Date: Wed, 08 Nov 2017 12:26:01 -0800	[thread overview]
Message-ID: <87h8u4bjqe.fsf@anholt.net> (raw)
In-Reply-To: <20171108200332.28949-4-hias@horus.com>


[-- Attachment #1.1: Type: text/plain, Size: 838 bytes --]

Matthias Reichl <hias@horus.com> writes:

> Sample rates are only restricted by the capabilities of the
> clock driver, so use SNDRV_PCM_RATE_CONTINUOUS instead of
> SNDRV_PCM_RATE_8000_192000.
>
> Tests (eg with pcm5122) have shown that bcm2835 works fine
> in 384kHz/32bit stereo mode, so change the maximum allowed
> rate from 192kHz to 384kHz.

The docs I've got say the maximum PCM clock freq is 25Mhz, so if my math
is right then 384kHz should be fine.  This patch is:

Reviewed-by: Eric Anholt <eric@anholt.net>

(There's a note about needing to be careful that the mash filter doesn't
give you frequencies over 25mhz, but we should be doing limits like that
in the clock driver)

I'm going to give the alsa folks a chance to look at the modes patches
first, since I know they've got strong opinions about them and I don't
at all.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



      reply	other threads:[~2017-11-08 20:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08 20:03 [PATCH 0/4] ASoC: bcm2835: Additional modes and constraint updates Matthias Reichl
     [not found] ` <20171108200332.28949-1-hias-vtPv7MOkFPkAvxtiuMwx3w@public.gmane.org>
2017-11-08 20:03   ` [PATCH 1/4] ASoC: bcm2835: Add support for TDM modes Matthias Reichl
2017-11-10 21:29     ` Applied "ASoC: bcm2835: Add support for TDM modes" to the asoc tree Mark Brown
2017-11-08 20:03   ` [PATCH 4/4] ASoC: bcm2835: Enforce full symmetry Matthias Reichl
2017-11-10 21:28     ` Applied "ASoC: bcm2835: Enforce full symmetry" to the asoc tree Mark Brown
2017-11-08 20:03 ` [PATCH 2/4] ASoC: bcm2835: Support left/right justified and DSP modes Matthias Reichl
2017-11-08 20:03 ` [PATCH 3/4] ASoC: bcm2835: Support additional samplerates up to 384kHz Matthias Reichl
2017-11-08 20:26   ` Eric Anholt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8u4bjqe.fsf@anholt.net \
    --to=eric@anholt.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=hias@horus.com \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox