From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BC9DC4345F for ; Tue, 30 Apr 2024 13:08:52 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A91F2741; Tue, 30 Apr 2024 15:08:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A91F2741 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1714482530; bh=r7FRtwI8zRzPvvCl2KCVkCnQ1HmMBmLozjO1kH0+tzY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=CM3z0ar6qPtnQmDQjSrlKcDKai9ZufhooxalvdrvjUICMRissvupIxFJxNp730w/3 SgRP9CXAW8VtYUXOQm+ZhueGgc26NvEwrPsld9vVGE94Rg6dwfr3KokG2ryuIK3iOc L2SWAIYoHLJLwpJTxIsfK5n+MVqIF/HbS3UB7Oxo= Received: by alsa1.perex.cz (Postfix, from userid 50401) id D4226F8057A; Tue, 30 Apr 2024 15:08:10 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 2BA2AF805A9; Tue, 30 Apr 2024 15:08:10 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C8BD5F80266; Tue, 30 Apr 2024 15:07:37 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4B23FF8003A for ; Tue, 30 Apr 2024 15:07:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4B23FF8003A Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tFjYY3ik; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9oZ4487R; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tFjYY3ik; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9oZ4487R Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8A9E43405D; Tue, 30 Apr 2024 13:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714482432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nz8N0tF3ZAzNA0MyZhuy8ig+mc3JPzOBiuWey73KYMw=; b=tFjYY3ik4DFWQ/rDjFDfkvcMtsG4+pt+FYsUquNUtBTyk/nfg4rYO7AMonqWsMTz+sQa6O 09b5Iju0hbTbO8Bi0jUneQqg9lDJWEYO9hc/B3/N30qRsAcdWhqwlzsv43fYEwLxYb/Oj8 Wx+evBumRboEZGb5S1mNhrC9ihQsrLY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714482432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nz8N0tF3ZAzNA0MyZhuy8ig+mc3JPzOBiuWey73KYMw=; b=9oZ4487RN1jyid4pLMdhXnk/Z496UXr5WcvJeB9l6tDr5ZO0Vgg7swsLQ7auJrYl7xmYSA QrRnIFrvX5yEX1Ag== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=tFjYY3ik; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9oZ4487R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714482432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nz8N0tF3ZAzNA0MyZhuy8ig+mc3JPzOBiuWey73KYMw=; b=tFjYY3ik4DFWQ/rDjFDfkvcMtsG4+pt+FYsUquNUtBTyk/nfg4rYO7AMonqWsMTz+sQa6O 09b5Iju0hbTbO8Bi0jUneQqg9lDJWEYO9hc/B3/N30qRsAcdWhqwlzsv43fYEwLxYb/Oj8 Wx+evBumRboEZGb5S1mNhrC9ihQsrLY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714482432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nz8N0tF3ZAzNA0MyZhuy8ig+mc3JPzOBiuWey73KYMw=; b=9oZ4487RN1jyid4pLMdhXnk/Z496UXr5WcvJeB9l6tDr5ZO0Vgg7swsLQ7auJrYl7xmYSA QrRnIFrvX5yEX1Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 562B9136A8; Tue, 30 Apr 2024 13:07:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id j+FuFADtMGY7LAAAD6G6ig (envelope-from ); Tue, 30 Apr 2024 13:07:12 +0000 Date: Tue, 30 Apr 2024 15:07:24 +0200 Message-ID: <87ikzzm22b.wl-tiwai@suse.de> From: Takashi Iwai To: Baojun Xu Cc: , , , , , , , , <13916275206@139.com>, , , , , , , , Subject: Re: [PATCH v4 2/3] ALSA: hda/tas2781: Tas2781 hda driver for SPI In-Reply-To: <20240430072544.1877-3-baojun.xu@ti.com> References: <20240430072544.1877-1-baojun.xu@ti.com> <20240430072544.1877-3-baojun.xu@ti.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Rspamd-Action: no action X-Rspamd-Queue-Id: 8A9E43405D X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-1.87 / 50.00]; BAYES_HAM(-2.86)[99.39%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_BLOCKED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[18]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FREEMAIL_ENVRCPT(0.00)[139.com,gmail.com]; FREEMAIL_CC(0.00)[kernel.org,linux.intel.com,gmail.com,perex.cz,ti.com,139.com,alsa-project.org,vger.kernel.org,intel.com,irl.hu]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[dt]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[ti.com:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns] Message-ID-Hash: 25YJQRHPCXCYBSQ37W2LTU5LYI5CK53F X-Message-ID-Hash: 25YJQRHPCXCYBSQ37W2LTU5LYI5CK53F X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: <> List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 30 Apr 2024 09:25:43 +0200, Baojun Xu wrote: > > Main source code for tas2781 hda driver for SPI. > > Signed-off-by: Baojun Xu That's far little description than wished. You can copy the contents of your cover letter to here, for example, for more detailed information. Second, and most: this patch breaks again the build. You added the code calling functions that aren't defined yet (appearing in the patch 3). Also, some functions seem defined but not really used, e.g. tasdevice_spi_calbin_remove(), and some are not needed to be global functions. thanks, Takashi