From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61D87C4332F for ; Thu, 3 Nov 2022 13:25:38 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 705CC164D; Thu, 3 Nov 2022 14:24:46 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 705CC164D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1667481936; bh=MUCZp63UeFfYyFXnqDbNGJK7wp6ZMidv23fy3ZU7ecQ=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cvSkHbMulQz1Y5hyFe+Neu0RLq2fCPZSazwCwpKlxTOm9XerwYJhGQL4G0CKrKfd9 NB/nwRzgNiV2KHnUxC/1etI9Cjp+KVs7coHSZkJsBpZpX9UAqu+VotXoXR9Bo5GZDu zBt6ZOW5LUvOl6GHZW87FmY+8rlLaRfC1bY9dWsA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 14731F80552; Thu, 3 Nov 2022 14:24:22 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A1F4AF80557; Thu, 3 Nov 2022 14:24:20 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A9FC1F8051C for ; Thu, 3 Nov 2022 14:24:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A9FC1F8051C Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="rnV7SPPh"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="jiC7tH+9" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1AC771F894; Thu, 3 Nov 2022 13:24:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667481854; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oSZ2qcuIFBfbYjPGuxuQ5WbJF/0fAgqD6TxyXRyQgVk=; b=rnV7SPPhvfaOMRT1ZQnixXY2V2TZ6Yhq84YpGx9v4bjXoIuQpJtB7pW8OX9fx8lMMYv2JZ cf5v7wl8O9Quf6LbC1AIEorZRbbLYoILXPhak9Bkov1u8n8rJ62KLjL4CpaHJbcbz1qVrc sooSNrtU7T54x3fOYg47p7rDE6xYoDU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667481854; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oSZ2qcuIFBfbYjPGuxuQ5WbJF/0fAgqD6TxyXRyQgVk=; b=jiC7tH+9tsy6x7qJIcwVG/fdDspTcPh0oOuDQtKi1r0sT5Us/4S5sDrhXE4NCfqT+Jf+eZ /c2Y4Se2P7RvN3DA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DDA7513480; Thu, 3 Nov 2022 13:24:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EPx/Nf3AY2NIWwAAMHmgww (envelope-from ); Thu, 03 Nov 2022 13:24:13 +0000 Date: Thu, 03 Nov 2022 14:24:13 +0100 Message-ID: <87iljwmarm.wl-tiwai@suse.de> From: Takashi Iwai To: Jason Montleon Subject: Re: [PATCH v2 1/2] ASoC: rt5514: fix legacy dai naming In-Reply-To: <87k04cmavy.wl-tiwai@suse.de> References: <87v8nwmgso.wl-tiwai@suse.de> <20221103131144.2942-1-jmontleo@redhat.com> <87k04cmavy.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: oder_chiou@realtek.com, cezary.rojewski@intel.com, ckeepax@opensource.cirrus.com, regressions@lists.linux.dev, tiwai@suse.com, alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com, broonie@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 03 Nov 2022 14:21:37 +0100, Takashi Iwai wrote: > > On Thu, 03 Nov 2022 14:11:43 +0100, > Jason Montleon wrote: > > > > Starting with 6.0-rc1 these messages are logged and the sound card > > is unavailable. Adding legacy_dai_naming to the rt5514-spi causes > > it to function properly again. > > > > [ 16.928454] kbl_r5514_5663_max kbl_r5514_5663_max: ASoC: CPU DAI > > spi-PRP0001:00 not registered > > [ 16.928561] platform kbl_r5514_5663_max: deferred probe pending > > Please avoid hanging on the existing thread if you resubmit a new > patch set. > > Also, more importantly, your Signed-off-by tag is missing. It's a > legal requirement. > > At the next time, run scripts/checkpatch.pl before the submission. > It'll catch such errors. Also, it's better to have a few more things in the patches: - Fixes tag indicating the buggy commit to be fixed - Link (or BugLink tag) to pointing to the kernel bugzilla URL - Cc-to-stable tag, to assure the fix going to 6.0.y stable tree Takashi