From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Simon <horms@verge.net.au>, Liam Girdwood <lgirdwood@gmail.com>
Subject: [PATCH 06/15] ASoC: rsnd: always call probe/remove for MUX
Date: Thu, 21 Jan 2016 01:56:59 +0000 [thread overview]
Message-ID: <87io2n4s18.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <87r3hb4s53.wl%kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
CTU/MUX/DVC/SSIU/SSI/Audio-DMAC-periperi might be used under multipath.
So, probe()/remove() need to be called multiple times.
This patch allows it.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
sound/soc/sh/rcar/core.c | 1 +
sound/soc/sh/rcar/rsnd.h | 14 +++++++-------
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c
index ad97ce3..ed09189 100644
--- a/sound/soc/sh/rcar/core.c
+++ b/sound/soc/sh/rcar/core.c
@@ -163,6 +163,7 @@ void rsnd_mod_quit(struct rsnd_mod *mod)
{
if (mod->clk)
clk_unprepare(mod->clk);
+ mod->clk = NULL;
}
void rsnd_mod_interrupt(struct rsnd_mod *mod,
diff --git a/sound/soc/sh/rcar/rsnd.h b/sound/soc/sh/rcar/rsnd.h
index 317dd79..c7b2ba0 100644
--- a/sound/soc/sh/rcar/rsnd.h
+++ b/sound/soc/sh/rcar/rsnd.h
@@ -237,29 +237,29 @@ struct rsnd_mod {
/*
* status
*
- * 0xH0000CBA
+ * 0xH0000CB0
*
- * A 0: probe 1: remove
* B 0: init 1: quit
* C 0: start 1: stop
*
* H is always called (see __rsnd_mod_call)
+ * H 0: probe 1: remove
* H 0: pcm_new
* H 0: fallback
* H 0: hw_params
*/
-#define __rsnd_mod_shift_probe 0
-#define __rsnd_mod_shift_remove 0
#define __rsnd_mod_shift_init 4
#define __rsnd_mod_shift_quit 4
#define __rsnd_mod_shift_start 8
#define __rsnd_mod_shift_stop 8
+#define __rsnd_mod_shift_probe 28 /* always called */
+#define __rsnd_mod_shift_remove 28 /* always called */
#define __rsnd_mod_shift_pcm_new 28 /* always called */
#define __rsnd_mod_shift_fallback 28 /* always called */
#define __rsnd_mod_shift_hw_params 28 /* always called */
-#define __rsnd_mod_add_probe 1
-#define __rsnd_mod_add_remove -1
+#define __rsnd_mod_add_probe 0
+#define __rsnd_mod_add_remove 0
#define __rsnd_mod_add_init 1
#define __rsnd_mod_add_quit -1
#define __rsnd_mod_add_start 1
@@ -269,7 +269,7 @@ struct rsnd_mod {
#define __rsnd_mod_add_hw_params 0
#define __rsnd_mod_call_probe 0
-#define __rsnd_mod_call_remove 1
+#define __rsnd_mod_call_remove 0
#define __rsnd_mod_call_init 0
#define __rsnd_mod_call_quit 1
#define __rsnd_mod_call_start 0
--
1.9.1
next prev parent reply other threads:[~2016-01-21 1:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 1:54 [PATCH 0/15] ASoC: rsnd: Ensure CTU/MUX works Kuninori Morimoto
2016-01-21 1:55 ` [PATCH 01/15] ASoC: rsnd: remove unsed *parent Kuninori Morimoto
2016-01-22 18:26 ` Applied "ASoC: rsnd: remove unsed *parent" to the asoc tree Mark Brown
2016-01-21 1:55 ` [PATCH 02/15] ASoC: rsnd: use rsnd_mod_init() for ADG Kuninori Morimoto
2016-01-22 18:26 ` Applied "ASoC: rsnd: use rsnd_mod_init() for ADG" to the asoc tree Mark Brown
2016-01-21 1:55 ` [PATCH 03/15] ASoC: rsnd: add debug message for rsnd_mod_call() Kuninori Morimoto
2016-01-22 18:26 ` Applied "ASoC: rsnd: add debug message for rsnd_mod_call()" to the asoc tree Mark Brown
2016-01-21 1:56 ` [PATCH 04/15] ASoC: rsnd: don't update status if rsnd_mod_call() doesn't match Kuninori Morimoto
2016-01-22 18:26 ` Applied "ASoC: rsnd: don't update status if rsnd_mod_call() doesn't match" to the asoc tree Mark Brown
2016-01-21 1:56 ` [PATCH 05/15] ASoC: rsnd: try to connect connected mod is not error Kuninori Morimoto
2016-01-22 18:26 ` Applied "ASoC: rsnd: try to connect connected mod is not error" to the asoc tree Mark Brown
2016-01-21 1:56 ` Kuninori Morimoto [this message]
2016-01-22 18:26 ` Applied "ASoC: rsnd: always call probe/remove for MUX" " Mark Brown
2016-01-21 1:57 ` [PATCH 07/15] ASoC: rsnd: don't overwrite io on rsnd_cmd_init() Kuninori Morimoto
2016-01-22 18:26 ` Applied "ASoC: rsnd: don't overwrite io on rsnd_cmd_init()" to the asoc tree Mark Brown
2016-01-21 1:57 ` [PATCH 08/15] ASoC: rsnd: select each SRC correctly for CMD data path Kuninori Morimoto
2016-01-22 18:26 ` Applied "ASoC: rsnd: select each SRC correctly for CMD data path" to the asoc tree Mark Brown
2016-01-21 1:58 ` [PATCH 09/15] ASoC: rsnd: each mod has status again for CTU/MUX support Kuninori Morimoto
2016-01-22 18:26 ` Applied "ASoC: rsnd: each mod has status again for CTU/MUX support" to the asoc tree Mark Brown
2016-01-21 1:58 ` [PATCH 10/15] ASoC: rsnd: attach Audio-DMAC-periperi correctly Kuninori Morimoto
2016-01-22 18:26 ` Applied "ASoC: rsnd: attach Audio-DMAC-periperi correctly" to the asoc tree Mark Brown
2016-01-21 1:58 ` [PATCH 11/15] ASoC: rsnd: ctu: add rsnd_mix_activation() Kuninori Morimoto
2016-01-22 18:26 ` Applied "ASoC: rsnd: ctu: add rsnd_mix_activation()" to the asoc tree Mark Brown
2016-01-21 1:59 ` [PATCH 12/15] ASoC: rsnd: ctu: add rsnd_ctu_halt() Kuninori Morimoto
2016-01-22 18:26 ` Applied "ASoC: rsnd: ctu: add rsnd_ctu_halt()" to the asoc tree Mark Brown
2016-01-21 1:59 ` [PATCH 13/15] ASoC: rsnd: ctu: settings matches to datasheet Kuninori Morimoto
2016-01-22 18:26 ` Applied "ASoC: rsnd: ctu: settings matches to datasheet" to the asoc tree Mark Brown
2016-01-21 1:59 ` [PATCH 14/15] ASoC: rsnd: tidyup Playback/Capture sequence Kuninori Morimoto
2016-01-22 18:26 ` Applied "ASoC: rsnd: tidyup Playback/Capture sequence" to the asoc tree Mark Brown
2016-01-21 2:00 ` [PATCH 15/15] ASoC: rsnd: disable SRC.out/in in same time Kuninori Morimoto
2016-01-22 18:26 ` Applied "ASoC: rsnd: disable SRC.out/in in same time" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87io2n4s18.wl%kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=horms@verge.net.au \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).