From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH] ASoC: simple-card: cpu_dai_name creates confusion when DT case Date: Thu, 27 Feb 2014 02:21:27 -0800 (PST) Message-ID: <87ios0etzw.wl%kuninori.morimoto.gx@gmail.com> References: <87eh2r9169.wl%kuninori.morimoto.gx@gmail.com> <20140227050726.GR9383@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by alsa0.perex.cz (Postfix) with ESMTP id C3EDB265835 for ; Thu, 27 Feb 2014 11:21:28 +0100 (CET) Received: by mail-pa0-f46.google.com with SMTP id rd3so2321032pab.33 for ; Thu, 27 Feb 2014 02:21:27 -0800 (PST) In-Reply-To: <20140227050726.GR9383@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Linux-ALSA , Simon , Liam Girdwood , Kuninori Morimoto List-Id: alsa-devel@alsa-project.org Hi Mark > > Basically, soc_bind_dai_link() checks > > cpu_dai->dev->of_node and dai_link->cpu_of_node in DT case. > > But after that it will check > > cpu_dai->name and dai_link->cpu_dai_name too. > > > > On the other hand, snd_soc_dai :: name is created by > > fmt_single_name() or fmt_multiple_name(). > > This looks like a valid issue which still affects current code but it > doesn't apply due changes on the latest topic/simple branch. Can you > please check and resend? OK I will send it again tomorrow. Thank you