From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CEC3C001B0 for ; Mon, 24 Jul 2023 09:02:09 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0468A206; Mon, 24 Jul 2023 11:01:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0468A206 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1690189327; bh=H9I/aFrmiJV343XToiqijxR1XlHD3M+s8SVfuMqYDuw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=L1exZEcvhGTJMn26uV//YvyZ3K+xubFSVlelm53GeZe8wWQKpLDujxlslWI0yLfTt 8ZNBg6put+hSB47RHuz4wQ5xsOqXO/mb/wMbucqIvSnStTP4wKZhwKSuAF19/g3IgG vftbcm09T+K13A33hLUsRPG1LFKZirIlS/zY7iuo= Received: by alsa1.perex.cz (Postfix, from userid 50401) id CF967F8019B; Mon, 24 Jul 2023 11:00:50 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 7F2A1F8019B; Mon, 24 Jul 2023 11:00:50 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5FB83F8019B; Mon, 24 Jul 2023 11:00:47 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 09F29F800D2 for ; Mon, 24 Jul 2023 11:00:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 09F29F800D2 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=yBHIhzs9; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Ba6g30PT Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 61B3D20596; Mon, 24 Jul 2023 09:00:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690189239; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3UEOejG3eAwInBAx5GadtQ9ckeym5ILp69OeEXZM21c=; b=yBHIhzs9qqfBFuuClPw2939wY9vIdy6kHapczmUpkkQIZ0wHojtCHmNGW5IIOw217jDtcl WjT2Jer+e76/xG22/5Evh5CIMWJa7fMQqWL6R+jbV3D7zQmlmK5rMV5ZLxsdZOL9ovUa7n tpO/kTWaBHYk8pgsNUKhITx6shk1iYQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690189239; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3UEOejG3eAwInBAx5GadtQ9ckeym5ILp69OeEXZM21c=; b=Ba6g30PTt3ZKTGRghwbmETKH+2hesUDpfv5yAjqUev4FME3PLz0gNWWY3/BjWpkg9jP0lt Gr2uV6rssdNUu6Bg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2B5F113476; Mon, 24 Jul 2023 09:00:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9baQCbc9vmRLGAAAMHmgww (envelope-from ); Mon, 24 Jul 2023 09:00:39 +0000 Date: Mon, 24 Jul 2023 11:00:38 +0200 Message-ID: <87jzupwuo9.wl-tiwai@suse.de> From: Takashi Iwai To: Stefan Binding Cc: Mark Brown , Jaroslav Kysela , Takashi Iwai , , , Subject: Re: [PATCH v2 00/11] Fix support for System Suspend for CS35L41 HDA In-Reply-To: <20230721151816.2080453-1-sbinding@opensource.cirrus.com> References: <20230721151816.2080453-1-sbinding@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: 2ZRWEUZ7J7HQIJG6RVPLUR277ORPC2KP X-Message-ID-Hash: 2ZRWEUZ7J7HQIJG6RVPLUR277ORPC2KP X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 21 Jul 2023 17:18:05 +0200, Stefan Binding wrote: > > There have been a couple of customer reports of intermittant issues after > system resume, where sometimes the DSP firmware stops responding. > Investigations into this issue show that there is a race between receiving > a prepare from the HDA core, and the firmware reload which is started by > the system resume. This can causes the Global Enable on the CS35L41 to be > enabled during the firmware load, which can sometimes cause issues in the > DSP. > > The existing system resume behaviour also did not resume the audio, if > audio was previously playing when it was suspended. > In addition, during investigation, it was found there were additional > problems in the System Resume sequence, as well as the Playback sequence > with External Boost, where the driver does not correctly follow its > enable sequence for this mode. This can cause additional issues such as > pops and clicks. > > This chain intends to correct the sequences for playback and system > suspend/resume so that the driver: obeys the external boost enable sequence; > resumes audio on system resume; and avoids the race condition on firmware > load and playback during system resume. > > Changes since v1: > - Split patch 1 into 2 separate patches > - Combine Patches 6 and 9 > > Stefan Binding (11): > ALSA: cs35l41: Use mbox command to enable speaker output for external > boost > ALSA: cs35l41: Poll for Power Up/Down rather than waiting a fixed > delay > ALSA: hda: cs35l41: Check mailbox status of pause command after > firmware load > ALSA: hda: cs35l41: Ensure we correctly re-sync regmap before system > suspending. > ALSA: hda: cs35l41: Ensure we pass up any errors during system > suspend. > ALSA: hda: cs35l41: Move Play and Pause into separate functions > ALSA: hda: hda_component: Add pre and post playback hooks to > hda_component > ALSA: hda: cs35l41: Use pre and post playback hooks > ALSA: hda: cs35l41: Rework System Suspend to ensure correct call > separation > ALSA: hda: cs35l41: Add device_link between HDA and cs35l41_hda > ALSA: hda: cs35l41: Ensure amp is only unmuted during playback Applied all patches now to for-next branch. thanks, Takashi