From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63427C7618A for ; Sun, 19 Mar 2023 08:13:35 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B83F683D; Sun, 19 Mar 2023 09:12:42 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B83F683D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1679213612; bh=vCyY7XvRqjvy233Mro83XJ4Vzdy5vA7uJqKk12H5Q/Y=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=CWbjhGZ8OUFTHEyhgkxTBES/30UOV3wYwipwz9RPo7g0Yul79Z6W1Q3quSgsgnvWd 6oVoyYHGNN1gpolbSijA1QNDJ+p9kx+1gRg4PnuQXZAAp1QbYj1o0sw3RK3wLzS3jS X67xxVQu7kbzjwxx7PAZ0abM6rLkvfKUZMnKVdLY= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 6EDD9F802E8; Sun, 19 Mar 2023 09:12:21 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 09B7FF8027B; Sun, 19 Mar 2023 09:12:17 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0E151F800C9 for ; Sun, 19 Mar 2023 09:12:15 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0E151F800C9 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=0JZXbeD8; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5vZ15FiN Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BBB9321B2C; Sun, 19 Mar 2023 08:12:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1679213534; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XTWPTgVfbJaJykAj83aY5/2Ng9TDpTjlaR8XdjuJMBo=; b=0JZXbeD83TBfzcTMwe6vdJ9nFKh/J0nYexzaJr2Yixyr8+q+PILLl16wkqKhWR/BQcKang UIUcMEVrKlW9Al9YqES7dzTBIQGY+23UwtLBZFdjER/KJcVFJuYtU6nbaiV3r1iqaxLuIR V1R5PYkukWaZJOb8uKVQqRaHcfx0AxA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1679213534; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XTWPTgVfbJaJykAj83aY5/2Ng9TDpTjlaR8XdjuJMBo=; b=5vZ15FiNSbvJPj7byrcU95ivrmIg2eFvtJQr6h0BYgngGjnUPfd7P5WB5MZWn23MiNR3nj xKSaFSGjw5lTWsBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 96486133E6; Sun, 19 Mar 2023 08:12:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id r64AJN7DFmRAPgAAMHmgww (envelope-from ); Sun, 19 Mar 2023 08:12:14 +0000 Date: Sun, 19 Mar 2023 09:12:14 +0100 Message-ID: <87jzzdma75.wl-tiwai@suse.de> From: Takashi Iwai To: Jiapeng Chong Subject: Re: [PATCH] ALSA: drivers: Remove the unused variable portman_read_data In-Reply-To: <87pm95mahe.wl-tiwai@suse.de> References: <20230317063338.18029-1-jiapeng.chong@linux.alibaba.com> <87pm95mahe.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: 7HIGXVUJFHKDTYVIMTLRPTDRQUNC4OKX X-Message-ID-Hash: 7HIGXVUJFHKDTYVIMTLRPTDRQUNC4OKX X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Abaci Robot X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sun, 19 Mar 2023 09:06:05 +0100, Takashi Iwai wrote: > > On Fri, 17 Mar 2023 07:33:38 +0100, > Jiapeng Chong wrote: > > > > Variable portman_read_data is not effectively used, so delete it. > > > > sound/drivers/portman2x4.c:195:18: warning: unused function 'portman_read_data'. > > > > Reported-by: Abaci Robot > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4557 > > Signed-off-by: Jiapeng Chong > > Thanks, applied now. ... and now I see Tom's patch removing one more unused one, so I took Tom's fix instead of yours. https://lore.kernel.org/r/20230318135229.1685266-1-trix@redhat.com thanks, Takashi