From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3E64C46467 for ; Tue, 10 Jan 2023 08:39:09 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5D92ACB79; Tue, 10 Jan 2023 09:38:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5D92ACB79 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1673339947; bh=rocWwoX0LGyzN8H1F/C2h9pI9C44XcJWx374mbqMkuY=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=bQKozXkiniEytJt+uQazB4tskDm1iC7SP5q1KLRQDhQtUv6BAVKO0spd28JJtZEpY zj7eVkiObpEljXNjFUsUHYVEQllqBuswPqoIld1g+1VVmEy61WtADzBKNX8bi1TzUp Bi38Fj2ob7Nkg3K4TTXzwYIP3vwJfeFrc9ad3diI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C6CB7F8057F; Tue, 10 Jan 2023 09:36:41 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 55F1AF8057E; Tue, 10 Jan 2023 09:36:40 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BAB65F8057E for ; Tue, 10 Jan 2023 09:36:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BAB65F8057E Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=sLt1j2De; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=DZuJmvUt Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0F895678BF; Tue, 10 Jan 2023 08:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1673339798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xvS//62VSffaOVkPd7AJ+WkPm2q+fEQoyqXPxSgE+Tc=; b=sLt1j2De2qQT5zPcMyDikiQPYwPstDNGwUA+QwDZTjMdEHh/s5GuDx/XkgrLZrCN0jpYtm r9IgMiVSFfcsQZ38yWwqsGfJvg7nDXXdaY2zBLTgU+35YhzPWPBlPxV4zmtKh15WqGnSk3 JD9CWhXokfnH500EdukLWNyDmWJtlME= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1673339798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xvS//62VSffaOVkPd7AJ+WkPm2q+fEQoyqXPxSgE+Tc=; b=DZuJmvUtsJf4nJ5sVotgf+gUVorDRkWgCrx6j8e8mSNd7NpIaS3LmCPyRIX2wUu3KiDfVM q3zzuibEavQ5jADw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E2BC01358A; Tue, 10 Jan 2023 08:36:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OUC5NpUjvWOyFgAAMHmgww (envelope-from ); Tue, 10 Jan 2023 08:36:37 +0000 Date: Tue, 10 Jan 2023 09:36:37 +0100 Message-ID: <87k01ueqga.wl-tiwai@suse.de> From: Takashi Iwai To: Luka Guzenko Subject: Re: [PATCH] ALSA: hda/realtek: Enable mute/micmute LEDs on HP Spectre x360 13-aw0xxx In-Reply-To: <20230109235840.26452-1-l.guzenko@web.de> References: <20230109235840.26452-1-l.guzenko@web.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, tiwai@suse.com, linux-kernel@vger.kernel.org Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 10 Jan 2023 00:58:40 +0100, Luka Guzenko wrote: > > The HP Spectre x360 13-aw0xxx devices use the ALC285 codec with GPIO 0x04 > controlling the micmute LED and COEF 0x0b index 8 controlling the mute LED. > A quirk was added to make these work as well as a fixup entry. > > Signed-off-by: Luka Guzenko > --- > sound/pci/hda/patch_realtek.c | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 3794b522c222..6a76a2eddd3c 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -4644,6 +4644,16 @@ static void alc285_fixup_hp_coef_micmute_led(struct hda_codec *codec, > } > } > > +static void alc285_fixup_hp_gpio_micmute_led(struct hda_codec *codec, > + const struct hda_fixup *fix, int action) > +{ > + struct alc_spec *spec = codec->spec; > + > + if (action != HDA_FIXUP_ACT_PRE_PROBE) > + spec->micmute_led_polarity = 1; Is this condition correct? It's usually other way round; a flag is set up only once at parsing. thanks, Takashi