From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBE86C4332F for ; Thu, 3 Nov 2022 13:22:39 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BC46786E; Thu, 3 Nov 2022 14:21:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BC46786E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1667481757; bh=dRQS/1XrHIoUp1dWM2rpQbkAKAaM68UYq02AwZvJKmY=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=KKUORsIaW4yFBXMlLWDAkgMiFpAp2HshAIOvrTdZ6Iwf0CClDVqisWpf4lw0S9fCM Gx5WSqRvuDGynGUiaLxi7smpnN+8WK62cIxa0IUl/BFnOkABx9RcfawhvuBxbLpKz9 /55Rw+QogXrd0vWjt6BkPXGLJw1ZW+BMIPlE4ij4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 67995F8051C; Thu, 3 Nov 2022 14:21:47 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 48020F8051E; Thu, 3 Nov 2022 14:21:46 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 11962F800BF for ; Thu, 3 Nov 2022 14:21:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 11962F800BF Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ZIg6r8aN"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="AD9zqpYx" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 75E8C1F890; Thu, 3 Nov 2022 13:21:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667481698; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F0LuFgq8fImKmqY+JS8BQeJ8PxjehuUiUqF+HKYhiYo=; b=ZIg6r8aNQnKSAidlNvxGl7qGPhxXx8YO/hpiEfm3u2YHVR34WyZZmR3cusQMdF4UYuPtfY 9Mrwhe1MZ6FHCV+7LgTu4yn2RQcL/24NNIUvHtx8k3sjNUsf/uf0kPZqhEcgSQJl+j8ZJb veBf2o5bTU5BoTJd4/Jp1jXogAjSYYI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667481698; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F0LuFgq8fImKmqY+JS8BQeJ8PxjehuUiUqF+HKYhiYo=; b=AD9zqpYx0wFmTAXpYlMJSXf10MFa/qYZufWiaITwKiGJDxTh0O9M5rYVotz5WAUJu7aWxL 9GKnfdZ6BsFxR+BA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 404E513480; Thu, 3 Nov 2022 13:21:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5qXpDmLAY2MHWgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 13:21:38 +0000 Date: Thu, 03 Nov 2022 14:21:37 +0100 Message-ID: <87k04cmavy.wl-tiwai@suse.de> From: Takashi Iwai To: Jason Montleon Subject: Re: [PATCH v2 1/2] ASoC: rt5514: fix legacy dai naming In-Reply-To: <20221103131144.2942-1-jmontleo@redhat.com> References: <87v8nwmgso.wl-tiwai@suse.de> <20221103131144.2942-1-jmontleo@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: oder_chiou@realtek.com, cezary.rojewski@intel.com, ckeepax@opensource.cirrus.com, regressions@lists.linux.dev, tiwai@suse.com, alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com, broonie@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 03 Nov 2022 14:11:43 +0100, Jason Montleon wrote: > > Starting with 6.0-rc1 these messages are logged and the sound card > is unavailable. Adding legacy_dai_naming to the rt5514-spi causes > it to function properly again. > > [ 16.928454] kbl_r5514_5663_max kbl_r5514_5663_max: ASoC: CPU DAI > spi-PRP0001:00 not registered > [ 16.928561] platform kbl_r5514_5663_max: deferred probe pending Please avoid hanging on the existing thread if you resubmit a new patch set. Also, more importantly, your Signed-off-by tag is missing. It's a legal requirement. At the next time, run scripts/checkpatch.pl before the submission. It'll catch such errors. thanks, Takashi > --- > sound/soc/codecs/rt5514-spi.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/sound/soc/codecs/rt5514-spi.c b/sound/soc/codecs/rt5514-spi.c > index 1a25a3787935..362663abcb89 100644 > --- a/sound/soc/codecs/rt5514-spi.c > +++ b/sound/soc/codecs/rt5514-spi.c > @@ -298,13 +298,14 @@ static int rt5514_spi_pcm_new(struct snd_soc_component *component, > } > > static const struct snd_soc_component_driver rt5514_spi_component = { > - .name = DRV_NAME, > - .probe = rt5514_spi_pcm_probe, > - .open = rt5514_spi_pcm_open, > - .hw_params = rt5514_spi_hw_params, > - .hw_free = rt5514_spi_hw_free, > - .pointer = rt5514_spi_pcm_pointer, > - .pcm_construct = rt5514_spi_pcm_new, > + .name = DRV_NAME, > + .probe = rt5514_spi_pcm_probe, > + .open = rt5514_spi_pcm_open, > + .hw_params = rt5514_spi_hw_params, > + .hw_free = rt5514_spi_hw_free, > + .pointer = rt5514_spi_pcm_pointer, > + .pcm_construct = rt5514_spi_pcm_new, > + .legacy_dai_naming = 1, > }; > > /** > -- > 2.37.3 >