From: Takashi Iwai <tiwai@suse.de>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ALSA: ice1712: remove redundant assignment to new
Date: Fri, 05 Aug 2022 15:07:30 +0200 [thread overview]
Message-ID: <87k07m260d.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220805120439.2341600-1-colin.i.king@gmail.com>
On Fri, 05 Aug 2022 14:04:39 +0200,
Colin Ian King wrote:
>
> The variable new is initialized with a value but it is never read. It is
> being re-assigned a new value in every case path in the following switch
> statement. The assignment is redundant and can be removed.
>
> Cleans up clang scan build warning:
> sound/pci/ice1712/quartet.c:569:8: warning: Although the value stored
> to 'new' is used in the enclosing expression, the value is never actually
> read from 'new' [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Thanks, applied.
Takashi
prev parent reply other threads:[~2022-08-05 13:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 12:04 [PATCH] ALSA: ice1712: remove redundant assignment to new Colin Ian King
2022-08-05 13:07 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k07m260d.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox