From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58274CCA47B for ; Mon, 13 Jun 2022 08:29:27 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9BCED1811; Mon, 13 Jun 2022 10:28:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9BCED1811 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1655108965; bh=YS7W5LEFiNR8QymBY78xBKoElsldG3fBrv7HznGXZJA=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Z+LxK8wxhfEJIHLLUPCp4dA4JXh4LW2DQ80KPQrxYxx919HFoN/fmpVc3IP/Dzt9C ihbOcsYQovT6QC5bdksVPhhkTu0f2mLJ0g8oXDrlAXJ3viLJ7toBo+tQ1oxBrUEMX3 +kMyH7WVDPk28N/CwL/wmIwRT6ZccXgk5jtbtwhQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2B354F800D8; Mon, 13 Jun 2022 10:28:35 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 832E4F804C1; Mon, 13 Jun 2022 10:28:32 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3AE07F80139 for ; Mon, 13 Jun 2022 10:28:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3AE07F80139 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="azS/4Ta5"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="BP30t2wT" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8031521C17; Mon, 13 Jun 2022 08:28:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1655108905; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fyz7LmGxxVwUoC4Yw/AusPEWPwnpn5VOS/anWl6FtwI=; b=azS/4Ta5ELcUOFwyQ6GrJ1CLhnCHyL3PwbgkTa7dHUpYWsr7JcYaYJ7iN7+GimWEYmBt+q UyNmaw1NUiipvsX1peQafNerUZAASHTSMtLPZZh/EseSZ9PlP0GddRZBJRp1DfFhxsgA0+ A682awVPcbDWjR0mt2Vdhz5sn03Komo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1655108905; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fyz7LmGxxVwUoC4Yw/AusPEWPwnpn5VOS/anWl6FtwI=; b=BP30t2wTvSJy/CwPAa6tPeoKrm/sGzCqV1O58gc+aVwSwyqDpQtCIcDMlkZBMhqgMs7P6X c3loYJGv8hpLpHDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 617DA13443; Mon, 13 Jun 2022 08:28:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qn/6Fin1pmLUKAAAMHmgww (envelope-from ); Mon, 13 Jun 2022 08:28:25 +0000 Date: Mon, 13 Jun 2022 10:28:24 +0200 Message-ID: <87k09l7ys7.wl-tiwai@suse.de> From: Takashi Iwai To: Hans de Goede Subject: Re: How to add 2 different SND_PCI_QUIRKs for 2 models with the same PCI subsys vend + prod ids? In-Reply-To: <7e3aa97a-77c9-3367-8929-a86049286d75@redhat.com> References: <7e3aa97a-77c9-3367-8929-a86049286d75@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: "nikitashvets@flyium.com" , "alsa-devel@alsa-project.org" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 13 Jun 2022 09:54:47 +0200, Hans de Goede wrote: > > Hi All, > > There is a problem with the sound on the Lenovo Yoga Duet 7 13IML05, which > requires a SND_PCI_QUIRK to fix. But there already is an existing quirk > for another Lenovo laptop using the same PCI subsys vend + prod ids. > > For more details see: > https://wiki.archlinux.org/title/Lenovo_Yoga_Duet_7_13IML05#Audio > > So I guess this means that we need to add a way to also include a DMI match > for SND_PCI_QUIRKs ? > > Maybe add a: > > const struct dmi_systemid *dmi_ids; > > member to struct snd_pci_quirk and a new > SND_PCI_QUIRK_DMI macro to set this? Do both machines have the very same codec? I couldn't find alsa-info.sh output for Duet 7, but at least, C940 seems with ALC298 (0x10ec0298), judging from https://bugzilla.kernel.org/show_bug.cgi?id=205755 If Duet 7 has a different codec (e.g. ALC287 0x10ec0287), we can distinguish from that. Takashi