* [PATCH v2 1/2] ASoC: tas2781: Add tas5828 support
@ 2025-09-26 4:33 Baojun Xu
2025-09-26 12:40 ` Mark Brown
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Baojun Xu @ 2025-09-26 4:33 UTC (permalink / raw)
To: broonie, tiwai
Cc: andriy.shevchenko, 13916275206, alsa-devel, shenghao-ding,
baojun.xu, linux-sound, linux-kernel, lgirdwood, robh, krzk+dt,
conor+dt, devicetree, k-yi, henry.lo, robinchen, jesse-ji,
will-wang, jim.shil, toastcheng, chinkaiting
TAS5828 have on-chip DSP without current/voltage feedback.
Signed-off-by: Baojun Xu <baojun.xu@ti.com>
---
v2:
- Update description for TAS5828
- Change commit tree to .../tiwai/sound.git.
---
include/sound/tas2781.h | 1 +
sound/soc/codecs/tas2781-i2c.c | 7 ++++++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/include/sound/tas2781.h b/include/sound/tas2781.h
index ddd997ac3..a37b4d67c 100644
--- a/include/sound/tas2781.h
+++ b/include/sound/tas2781.h
@@ -122,6 +122,7 @@ enum audio_device {
TAS2781,
TAS5825,
TAS5827,
+ TAS5828,
TAS_OTHERS,
};
diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c
index 1539b7088..f62a71dca 100644
--- a/sound/soc/codecs/tas2781-i2c.c
+++ b/sound/soc/codecs/tas2781-i2c.c
@@ -110,6 +110,7 @@ static const struct i2c_device_id tasdevice_id[] = {
{ "tas2781", TAS2781 },
{ "tas5825", TAS5825 },
{ "tas5827", TAS5827 },
+ { "tas5828", TAS5828 },
{}
};
MODULE_DEVICE_TABLE(i2c, tasdevice_id);
@@ -126,6 +127,7 @@ static const struct of_device_id tasdevice_of_match[] = {
{ .compatible = "ti,tas2781" },
{ .compatible = "ti,tas5825" },
{ .compatible = "ti,tas5827" },
+ { .compatible = "ti,tas5828" },
{},
};
MODULE_DEVICE_TABLE(of, tasdevice_of_match);
@@ -1665,7 +1667,7 @@ static void tasdevice_fw_ready(const struct firmware *fmw,
}
tas_priv->fw_state = TASDEVICE_DSP_FW_ALL_OK;
- /* There is no calibration required for TAS5825/TAS5827. */
+ /* There is no calibration required for TAS5825/TAS5827/TAS5828. */
if (tas_priv->chip_id < TAS5825) {
ret = tasdevice_create_cali_ctrls(tas_priv);
if (ret) {
@@ -1722,6 +1724,7 @@ static void tasdevice_fw_ready(const struct firmware *fmw,
case TAS2781:
case TAS5825:
case TAS5827:
+ case TAS5828:
/* If DSP FW fail, DSP kcontrol won't be created. */
tasdevice_dsp_remove(tas_priv);
}
@@ -1884,6 +1887,7 @@ static int tasdevice_codec_probe(struct snd_soc_component *codec)
break;
case TAS5825:
case TAS5827:
+ case TAS5828:
p = (struct snd_kcontrol_new *)tas5825_snd_controls;
size = ARRAY_SIZE(tas5825_snd_controls);
break;
@@ -2056,6 +2060,7 @@ static const struct acpi_device_id tasdevice_acpi_match[] = {
{ "TXNW2781", TAS2781 },
{ "TXNW5825", TAS5825 },
{ "TXNW5827", TAS5827 },
+ { "TXNW5828", TAS5828 },
{},
};
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] ASoC: tas2781: Add tas5828 support
2025-09-26 4:33 [PATCH v2 1/2] ASoC: tas2781: Add tas5828 support Baojun Xu
@ 2025-09-26 12:40 ` Mark Brown
[not found] ` <20250926043339.8419-2-baojun.xu@ti.com>
2025-09-26 18:13 ` [PATCH v2 1/2] " Takashi Iwai
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2025-09-26 12:40 UTC (permalink / raw)
To: Baojun Xu
Cc: tiwai, andriy.shevchenko, 13916275206, alsa-devel, shenghao-ding,
linux-sound, linux-kernel, lgirdwood, robh, krzk+dt, conor+dt,
devicetree, k-yi, henry.lo, robinchen, jesse-ji, will-wang,
jim.shil, toastcheng, chinkaiting
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
On Fri, Sep 26, 2025 at 12:33:38PM +0800, Baojun Xu wrote:
> TAS5828 have on-chip DSP without current/voltage feedback.
Reviewed-by: Mark Brown <broonie@kernel.org>
Takashi, this would need to go via your tree (though I guess at this
point it's likely to be after the merge window and I can pick it up).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] ASoC: tas2781: Add tas5828 support
[not found] ` <20250926043339.8419-2-baojun.xu@ti.com>
@ 2025-09-26 12:40 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2025-09-26 12:40 UTC (permalink / raw)
To: Baojun Xu
Cc: tiwai, andriy.shevchenko, 13916275206, alsa-devel, shenghao-ding,
linux-sound, linux-kernel, lgirdwood, robh, krzk+dt, conor+dt,
devicetree, k-yi, henry.lo, robinchen, jesse-ji, will-wang,
jim.shil, toastcheng, chinkaiting
[-- Attachment #1: Type: text/plain, Size: 150 bytes --]
On Fri, Sep 26, 2025 at 12:33:39PM +0800, Baojun Xu wrote:
> Update ti,tas2781.yaml for adding TAS5828.
Reviewed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] ASoC: tas2781: Add tas5828 support
2025-09-26 4:33 [PATCH v2 1/2] ASoC: tas2781: Add tas5828 support Baojun Xu
2025-09-26 12:40 ` Mark Brown
[not found] ` <20250926043339.8419-2-baojun.xu@ti.com>
@ 2025-09-26 18:13 ` Takashi Iwai
2 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2025-09-26 18:13 UTC (permalink / raw)
To: Baojun Xu
Cc: broonie, andriy.shevchenko, 13916275206, alsa-devel,
shenghao-ding, linux-sound, linux-kernel, lgirdwood, robh,
krzk+dt, conor+dt, devicetree, k-yi, henry.lo, robinchen,
jesse-ji, will-wang, jim.shil, toastcheng, chinkaiting
On Fri, 26 Sep 2025 06:33:38 +0200,
Baojun Xu wrote:
>
> TAS5828 have on-chip DSP without current/voltage feedback.
>
> Signed-off-by: Baojun Xu <baojun.xu@ti.com>
Please use a different subject for each patch. Both patches are 100%
identical subject, and that makes harder to identify.
thanks,
Takashi
>
> ---
> v2:
> - Update description for TAS5828
> - Change commit tree to .../tiwai/sound.git.
> ---
> include/sound/tas2781.h | 1 +
> sound/soc/codecs/tas2781-i2c.c | 7 ++++++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/include/sound/tas2781.h b/include/sound/tas2781.h
> index ddd997ac3..a37b4d67c 100644
> --- a/include/sound/tas2781.h
> +++ b/include/sound/tas2781.h
> @@ -122,6 +122,7 @@ enum audio_device {
> TAS2781,
> TAS5825,
> TAS5827,
> + TAS5828,
> TAS_OTHERS,
> };
>
> diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c
> index 1539b7088..f62a71dca 100644
> --- a/sound/soc/codecs/tas2781-i2c.c
> +++ b/sound/soc/codecs/tas2781-i2c.c
> @@ -110,6 +110,7 @@ static const struct i2c_device_id tasdevice_id[] = {
> { "tas2781", TAS2781 },
> { "tas5825", TAS5825 },
> { "tas5827", TAS5827 },
> + { "tas5828", TAS5828 },
> {}
> };
> MODULE_DEVICE_TABLE(i2c, tasdevice_id);
> @@ -126,6 +127,7 @@ static const struct of_device_id tasdevice_of_match[] = {
> { .compatible = "ti,tas2781" },
> { .compatible = "ti,tas5825" },
> { .compatible = "ti,tas5827" },
> + { .compatible = "ti,tas5828" },
> {},
> };
> MODULE_DEVICE_TABLE(of, tasdevice_of_match);
> @@ -1665,7 +1667,7 @@ static void tasdevice_fw_ready(const struct firmware *fmw,
> }
> tas_priv->fw_state = TASDEVICE_DSP_FW_ALL_OK;
>
> - /* There is no calibration required for TAS5825/TAS5827. */
> + /* There is no calibration required for TAS5825/TAS5827/TAS5828. */
> if (tas_priv->chip_id < TAS5825) {
> ret = tasdevice_create_cali_ctrls(tas_priv);
> if (ret) {
> @@ -1722,6 +1724,7 @@ static void tasdevice_fw_ready(const struct firmware *fmw,
> case TAS2781:
> case TAS5825:
> case TAS5827:
> + case TAS5828:
> /* If DSP FW fail, DSP kcontrol won't be created. */
> tasdevice_dsp_remove(tas_priv);
> }
> @@ -1884,6 +1887,7 @@ static int tasdevice_codec_probe(struct snd_soc_component *codec)
> break;
> case TAS5825:
> case TAS5827:
> + case TAS5828:
> p = (struct snd_kcontrol_new *)tas5825_snd_controls;
> size = ARRAY_SIZE(tas5825_snd_controls);
> break;
> @@ -2056,6 +2060,7 @@ static const struct acpi_device_id tasdevice_acpi_match[] = {
> { "TXNW2781", TAS2781 },
> { "TXNW5825", TAS5825 },
> { "TXNW5827", TAS5827 },
> + { "TXNW5828", TAS5828 },
> {},
> };
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-11-10 14:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-26 4:33 [PATCH v2 1/2] ASoC: tas2781: Add tas5828 support Baojun Xu
2025-09-26 12:40 ` Mark Brown
[not found] ` <20250926043339.8419-2-baojun.xu@ti.com>
2025-09-26 12:40 ` [PATCH v2 2/2] " Mark Brown
2025-09-26 18:13 ` [PATCH v2 1/2] " Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).