Re: [PATCH] ALSA: hda/realtek: Remove Framework Laptop 16 from quirks

Mario Limonciello
2024-06-05T17:04:56Z

On 6/5/2024 12:01, Dustin L. Howett wrote:
> The Framework Laptop 16 does not have a combination headphone/headset
> 3.5mm jack; however, applying the pincfg from the Laptop 13 (nid=0x19)
> erroneously informs hda that the node is present.

But doesn't the audio card work this way?

>
> Fixes: 8804fa04a492 ("ALSA: hda/realtek: Add Framework laptop 16 to quirks")
> Signed-off-by: Dustin L. Howett <dustin@howett.net>
> ---
> sound/pci/hda/patch_realtek.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index e3c0b9d5552d..127f5933abd7 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10605,7 +10605,6 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", ALC256_FIXUP_INTEL_NUC10),
> SND_PCI_QUIRK(0x8086, 0x3038, "Intel NUC 13", ALC295_FIXUP_CHROME_BOOK),
> SND_PCI_QUIRK(0xf111, 0x0001, "Framework Laptop", ALC295_FIXUP_FRAMEWORK_LAPTOP_MIC_NO_PRESENCE),
> - SND_PCI_QUIRK(0xf111, 0x0005, "Framework Laptop", ALC295_FIXUP_FRAMEWORK_LAPTOP_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0xf111, 0x0006, "Framework Laptop", ALC295_FIXUP_FRAMEWORK_LAPTOP_MIC_NO_PRESENCE),
>
> #if 0
>
> ---
> base-commit: 7b44d5381e541de3da3cee2e948456b250f41f25
> change-id: 20240605-alsa-hda-realtek-remove-framework-laptop-16-from-quirks-dc60267cb5e7
>
> Best regards,