From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E430C4345F for ; Thu, 18 Apr 2024 15:37:52 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E4CE9DF8; Thu, 18 Apr 2024 17:37:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E4CE9DF8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1713454670; bh=2I36Eko68aUI5g/DQONb2pTb1RZqa+2vnBOO8kZT6us=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=CubmyYe+KOt6u5F6/ZIt61Hhh1qrCIDnmNxKZQzy0XeapRqbTsqdu4xOrEqP3qJaM Ld8JWt7GJfy5E90+2kT9cPLJbInDtwvvPYxEBSnFDl+py3jQcShaSOL+RzEANXlRF3 5FqFP3JevngIFw7qZxrV5jVekR7YHbIHjZW7QWPg= Received: by alsa1.perex.cz (Postfix, from userid 50401) id B9C4DF805A0; Thu, 18 Apr 2024 17:37:15 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 13A3EF805A1; Thu, 18 Apr 2024 17:37:15 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6EF7DF8025A; Thu, 18 Apr 2024 17:37:10 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 34D09F8013D for ; Thu, 18 Apr 2024 17:36:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 34D09F8013D Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=116hrGFb; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=RS/StU3F; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=y2q5e1+9; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=0XpPso11 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D5467350E3; Thu, 18 Apr 2024 15:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713454618; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FenP6M5Gv7bHL0FXpLwiYWJ4mVpgIU9DyVa7jR8WpPI=; b=116hrGFbo+sg8+02Vdxo+GJXn0RqRYTv9Vb6/Fofd0mh/5l3QZH33Av53kQ59KGA7Srzkx 12xKNE29xsaqsbnt+O/qXI/yd/HKUe24Pefsfi1gf0xX5JGH+1fPt0KH519yFNoNyFzTNp 8iFckHof9xDaORWcx0IPT4+ZTp5eOsU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713454618; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FenP6M5Gv7bHL0FXpLwiYWJ4mVpgIU9DyVa7jR8WpPI=; b=RS/StU3FjzjTiYYNjGEuLxB3XJVGARjdWMz22LfJIt5CluuHmENmwRjCP2rnmvS/zL6LFY 7GXhsEJz1hZ0aRDA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713454617; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FenP6M5Gv7bHL0FXpLwiYWJ4mVpgIU9DyVa7jR8WpPI=; b=y2q5e1+9+s38McIubN8gTubZ2p2TTfxUncZVOv0aSFxrBONldB7IJhWLVrtk07hx2qhDQr OtrpBJ8pa62Y5rF9L6piehIOCSzndmjlbEqVkMxSKPDeHysz+XioY695L8RkIIHY8Tciy4 //JN0t5oWnWVU6NDc/k/kRVZ7XYXz3Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713454617; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FenP6M5Gv7bHL0FXpLwiYWJ4mVpgIU9DyVa7jR8WpPI=; b=0XpPso11j8JtXDvkZ3wkGWZb1pxNOZ9vsyM5pJqf+V2USqd+7QsYZ9btqSw8hyWQIGOj6+ MhzPeyJxEVwV8cDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AA02F1384C; Thu, 18 Apr 2024 15:36:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id egk2KBk+IWZqPQAAD6G6ig (envelope-from ); Thu, 18 Apr 2024 15:36:57 +0000 Date: Thu, 18 Apr 2024 17:37:06 +0200 Message-ID: <87le5awul9.wl-tiwai@suse.de> From: Takashi Iwai To: Kailang Cc: " (alsa-devel@alsa-project.org)" Subject: Re: Thinkpad with ALC1318 has a chance of damaging the IC In-Reply-To: References: <87o7a7xkas.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spamd-Result: default: False [-3.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_DN_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email] Message-ID-Hash: QW7CPU5OQTRY4VAV5UV55T2KR6FG23J7 X-Message-ID-Hash: QW7CPU5OQTRY4VAV5UV55T2KR6FG23J7 X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 18 Apr 2024 08:33:42 +0200, Kailang wrote: > > Hi Takashi, > > New patch was attached. > new additional function was request from Lenovo. I got a compile error. The check should be rather if (codec->core.dev.power.power_state.event == PM_EVENT_FREEZE) Maybe better to define is_s4_suspend() just like is_s4_resume(). And, please rebase the patch to the latest for-linus branch of sound.git tree. thanks, Takashi > > BR, > Kailang > > > -----Original Message----- > > From: Takashi Iwai > > Sent: Thursday, April 18, 2024 2:22 PM > > To: Kailang > > Cc: (alsa-devel@alsa-project.org) > > Subject: Re: Thinkpad with ALC1318 has a chance of damaging the IC > > > > > > External mail. > > > > > > > > On Mon, 15 Apr 2024 11:27:50 +0200, > > Kailang wrote: > > > > > > Hi Takashi, > > > > > > Please don't apply this patch. > > > They want to add stream open to enable GPIO3 functions. > > > > OK, let me know if the new patch is ready. > > > > > > thanks, > > > > Takashi > > > > > > > > BR, > > > Kailang > > > > > > > -----Original Message----- > > > > From: Kailang > > > > Sent: Wednesday, April 10, 2024 5:23 PM > > > > To: Takashi Iwai (tiwai@suse.de) > > > > Cc: (alsa-devel@alsa-project.org) > > > > Subject: Thinkpad with ALC1318 has a chance of damaging the IC > > > > > > > > Hi Takashi, > > > > > > > > Thinkpad with ALC1318 has a chance of damaging the IC at S4 resume. > > > > > > > > BR, > > > > Kailang >