From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CCC1C77B75 for ; Tue, 18 Apr 2023 09:46:06 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C7708E7F; Tue, 18 Apr 2023 11:45:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C7708E7F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1681811163; bh=DYYvmp+uFugmtvn+/Tg4TeTvWuHUMZmfqfdWsNsINnU=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=sd/CCV74jAOUH9U4lRP0NCqSg35CbizD7x7o0Phv/42ZDlfxKCcXshsnOuV8cpnFK HPbFlsuHoXcuXGEd4ChAIgtKxPxJjJ0TsHqQhpmHgLVfjXmJbwPIAY/zYmkoHCb6c7 XldhSm+kUAdClyRflDfil4hdew/tcwA5WDy8SGYo= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 36862F80533; Tue, 18 Apr 2023 11:45:04 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 03061F80533; Tue, 18 Apr 2023 11:45:01 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 992F5F80212 for ; Tue, 18 Apr 2023 11:44:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 992F5F80212 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Ku6jUIEI; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=e2L9IOmp Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0F1641F8D5; Tue, 18 Apr 2023 09:44:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681811095; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h2DNN9uAK/0LGB1yyCJ/gV0l/zgtfRP7lir/w0VgvNg=; b=Ku6jUIEIO0ZX3eA0cnLitm2O8jPO64lxUk9wh5NVhpKkU8SbTT8Bi2xMrs2oxfoi42kE81 Qd+CI0ZZ0lpw4gBuJZci0SbzEBTK5XctP/WLP3CiqPH1PbFLCin1lW5CwV9eMd6HtkyyNe pSlZ9Ir4YaehH1nC0KUhUE5vptqp7L8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681811095; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h2DNN9uAK/0LGB1yyCJ/gV0l/zgtfRP7lir/w0VgvNg=; b=e2L9IOmppkEfnZkYo7lT7LLPkg651ZsvqGufKr+7UH8HFQJizvGOwJtsDQGQkj8kiJ4Fmv 6MZhWl0BqAy9SpDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DA00F13581; Tue, 18 Apr 2023 09:44:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kkF4NJZmPmSfMgAAMHmgww (envelope-from ); Tue, 18 Apr 2023 09:44:54 +0000 Date: Tue, 18 Apr 2023 11:44:53 +0200 Message-ID: <87leip4j8q.wl-tiwai@suse.de> From: Takashi Iwai To: reaperli Subject: Re: [PATCH] ALSA: hda: Glenfly: add HD Audio PCI IDs and HDMI Codec Vendor IDs. In-Reply-To: <20230418083312.5208-1-reaperlioc@glenfly.com> References: <20230418083312.5208-1-reaperlioc@glenfly.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: WASMKNBEUUOODG5TKY7FLQFVSU46P4AX X-Message-ID-Hash: WASMKNBEUUOODG5TKY7FLQFVSU46P4AX X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: tiwai@suse.com, linux-kernel@vger.kernel.org, jasontao , alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 18 Apr 2023 10:33:12 +0200, reaperli wrote: > > From: jasontao > > Add a set of HD Audio PCI IDS, and the HDMI codec vendor IDs for > Glenfly Arise. > > Signed-off-by: jasontao > Signed-off-by: reaperli The patch looks OK now, but could you submit to alsa-devel ML at the next time? About details in the patch: > @@ -1743,6 +1745,8 @@ static int default_bdl_pos_adj(struct azx *chip) > } > > switch (chip->driver_type) { > + case AZX_DRIVER_GFHDMI: > + return 128; So this looks pretty high in comparison with other chips. It means that the actual position is much behind the reported position. Due to a large FIFO? Or what reason? > @@ -1859,6 +1863,9 @@ static int azx_first_init(struct azx *chip) > } > #endif > > + if (chip->driver_type == AZX_DRIVER_GFHDMI) > + bus->polling_mode = 1; This looks odd, too. Doesn't the hardware give any interrupt back upon the CORB/RIRB response? > --- a/sound/pci/hda/patch_hdmi.c > +++ b/sound/pci/hda/patch_hdmi.c > @@ -4489,6 +4489,18 @@ static int patch_via_hdmi(struct hda_codec *codec) > return patch_simple_hdmi(codec, VIAHDMI_CVT_NID, VIAHDMI_PIN_NID); > } > > +static int patch_gf_hdmi(struct hda_codec *codec) > +{ > + int err; > + > + err = patch_generic_hdmi(codec); > + if (err) > + return err; > + > + codec->no_sticky_stream = 1; This hack is needed for what reason? thanks, Takashi